All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pablo Neira <pablo@netfilter.org>
To: KOVACS Krisztian <hidden@balabit.hu>
Cc: Harald Welte <laforge@netfilter.org>,
	netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH 3/3] CLUSTERIP: use a bitmap to store node responsibility data
Date: Tue, 30 Aug 2005 15:29:31 +0200	[thread overview]
Message-ID: <43145F3B.4050706@netfilter.org> (raw)
In-Reply-To: <20050830121550.543376000@nienna.balabit>

Hi Krisztian,

KOVACS Krisztian wrote:
> @@ -55,8 +56,7 @@
>  	u_int8_t clustermac[ETH_ALEN];		/* the MAC address */
>  	struct net_device *dev;			/* device */
>  	u_int16_t num_total_nodes;		/* total number of nodes */
> -	u_int16_t num_local_nodes;		/* number of local nodes */
> -	u_int16_t local_nodes[CLUSTERIP_MAX_NODES];	/* node number array */
> +	unsigned long local_nodes;		/* node number array */

I'm afraid that this breaks backward compatibility. Although CLUSTERIP 
is marked as experimental.

@Harald: Should we respect backward compatibility in this case?

--
Pablo

  reply	other threads:[~2005-08-30 13:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-30 12:15 [PATCH 0/3] CLUSTERIP: Multiple CLUSTERIP patches KOVACS Krisztian
2005-08-30 12:15 ` [PATCH 1/3] CLUSTERIP: fix memcpy() length typo KOVACS Krisztian
2005-08-30 14:05   ` Harald Welte
2005-08-30 12:15 ` [PATCH 2/3] CLUSTERIP: introduce reference counting for entries KOVACS Krisztian
2005-08-30 14:07   ` Harald Welte
2005-08-30 15:26     ` KOVACS Krisztian
2005-09-13 12:54       ` Harald Welte
2005-09-13 15:16         ` KOVACS Krisztian
2005-09-23 14:00           ` Harald Welte
2005-08-30 12:15 ` [PATCH 3/3] CLUSTERIP: use a bitmap to store node responsibility data KOVACS Krisztian
2005-08-30 13:29   ` Pablo Neira [this message]
2005-08-30 13:34     ` KOVACS Krisztian
2005-08-30 15:18       ` Pablo Neira

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43145F3B.4050706@netfilter.org \
    --to=pablo@netfilter.org \
    --cc=hidden@balabit.hu \
    --cc=laforge@netfilter.org \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.