[-mm patch] FB_GEODE should depend on PCI

[-mm patch] FB_GEODE should depend on PCI

[Adrian Bunk]

Due to fbdev-geode-updates.patch, building with CONFIG_PCI=n results in 
the following error:

<--  snip  -->

...
  CC [M]  drivers/video/geode/gx1fb_core.o
drivers/video/geode/gx1fb_core.c: In function 'gx1fb_map_video_memory':
drivers/video/geode/gx1fb_core.c:218: warning: implicit declaration of 
function 'pci_request_region'
drivers/video/geode/gx1fb_core.c: In function 'gx1fb_probe':
drivers/video/geode/gx1fb_core.c:372: warning: implicit declaration of 
function 'pci_release_region'
...
if [ -r System.map -a -x /sbin/depmod ]; then /sbin/depmod -ae -F System.map  2.6.13-mm1; fi
WARNING: /lib/modules/2.6.13-mm1/kernel/drivers/video/geode/gx1fb.ko needs unknown symbol pci_release_region

<--  snip  -->


Since the driver doesn't seem to be working without pci_request_region() 
this patch adds the required dependency on PCI.

The dependency is placed at FB_GEODE since there's (at least currently) 
no reason to show this option if no driver depending on it is available 
without PCI.

Additionally, it removes two superfluous "default n".


Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.13-mm1-full/drivers/video/geode/Kconfig.old	2005-09-03 13:55:41.000000000 +0200
+++ linux-2.6.13-mm1-full/drivers/video/geode/Kconfig	2005-09-03 13:56:17.000000000 +0200
@@ -3,15 +3,13 @@
 #
 config FB_GEODE
 	bool "AMD Geode family framebuffer support (EXPERIMENTAL)"
-	default n
-	depends on FB && EXPERIMENTAL && X86
+	depends on FB && PCI && EXPERIMENTAL && X86
 	---help---
 	  Say 'Y' here to allow you to select framebuffer drivers for
 	  the AMD Geode family of processors.
 
 config FB_GEODE_GX1
 	tristate "AMD Geode GX1 framebuffer support (EXPERIMENTAL)"
-	default n
 	depends on FB_GEODE && EXPERIMENTAL
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA

Re: [-mm patch] FB_GEODE should depend on PCI

[Alan Cox]

On Sad, 2005-09-03 at 14:01 +0200, Adrian Bunk wrote:
> Due to fbdev-geode-updates.patch, building with CONFIG_PCI=n results in 
> the following error:

All the Geodes have PCI or internal PCI emulation so that change makes
sense.