All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fix SCSI_IOCTL_PROBE_HOST
@ 2005-09-06 12:03 Christoph Hellwig
  0 siblings, 0 replies; only message in thread
From: Christoph Hellwig @ 2005-09-06 12:03 UTC (permalink / raw)
  To: jejb; +Cc: linux-scsi

This returns always false with new-style drivers right now.  Make it
return always true instead, as a host must be present if we are able
to call the ioctl (without a host attached there would be no device
node to call on..)


Index: scsi-misc-2.6/drivers/scsi/scsi_ioctl.c
===================================================================
--- scsi-misc-2.6.orig/drivers/scsi/scsi_ioctl.c	2005-09-06 14:11:23.000000000 +0200
+++ scsi-misc-2.6/drivers/scsi/scsi_ioctl.c	2005-09-06 14:16:18.000000000 +0200
@@ -30,20 +30,20 @@
 
 #define MAX_BUF PAGE_SIZE
 
-/*
- * If we are told to probe a host, we will return 0 if  the host is not
- * present, 1 if the host is present, and will return an identifying
- * string at *arg, if arg is non null, filling to the length stored at
- * (int *) arg
+/**
+ * ioctl_probe  --  return host identification
+ * @host:	host to identify
+ * @buffer:	userspace buffer for identification
+ *
+ * Return an identifying string at @buffer, if @buffer is non-NULL, filling
+ * to the length stored at * (int *) @buffer.
  */
-
 static int ioctl_probe(struct Scsi_Host *host, void __user *buffer)
 {
 	unsigned int len, slen;
 	const char *string;
-	int temp = host->hostt->present;
 
-	if (temp && buffer) {
+	if (buffer) {
 		if (get_user(len, (unsigned int __user *) buffer))
 			return -EFAULT;
 
@@ -59,7 +59,7 @@
 				return -EFAULT;
 		}
 	}
-	return temp;
+	return 1;
 }
 
 /*

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-09-06 12:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-06 12:03 [PATCH] fix SCSI_IOCTL_PROBE_HOST Christoph Hellwig

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.