From: Ravikiran G Thirumalai <kiran@scalex86.org>
To: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
"Shai Fultheim (Shai@scalex86.org)" <shai@scalex86.org>,
Alok Kataria <alokk@calsoftinc.com>
Subject: [patch 4/4] ide: Break ide_lock -- remove ide_lock from piix driver
Date: Tue, 6 Sep 2005 16:44:29 -0700 [thread overview]
Message-ID: <20050906234429.GE3642@localhost.localdomain> (raw)
In-Reply-To: <20050906233322.GA3642@localhost.localdomain>
Patch to convert piix driver to use per-driver/hwgroup lock and kill
ide_lock. In the case of piix, hwgroup->lock should be sufficient.
Signed-off-by: Ravikiran Thirumalai <kiran@scalex86.org>
Index: linux-2.6.13/drivers/ide/pci/piix.c
===================================================================
--- linux-2.6.13.orig/drivers/ide/pci/piix.c 2005-09-06 12:00:25.000000000 -0700
+++ linux-2.6.13/drivers/ide/pci/piix.c 2005-09-06 13:22:49.000000000 -0700
@@ -231,7 +231,6 @@
pio = ide_get_best_pio_mode(drive, pio, 5, NULL);
spin_lock_irqsave(&hwgroup->lock, flags);
- spin_lock(&ide_lock);
pci_read_config_word(dev, master_port, &master_data);
if (is_slave) {
master_data = master_data | 0x4000;
@@ -251,7 +250,6 @@
pci_write_config_word(dev, master_port, master_data);
if (is_slave)
pci_write_config_byte(dev, slave_port, slave_data);
- spin_unlock(&ide_lock);
spin_unlock_irqrestore(&hwgroup->lock, flags);
}
next prev parent reply other threads:[~2005-09-06 23:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-06 23:33 [patch 0/4] ide: Break ide_lock to per-hwgroup lock Ravikiran G Thirumalai
2005-09-06 23:37 ` [patch 1/4] ide: Break ide_lock -- Move hwif tuning code after hwif_init Ravikiran G Thirumalai
2005-09-06 23:40 ` [patch 2/4] ide: Break ide_lock -- replace ide_lock with hwgroup->lock in core ide Ravikiran G Thirumalai
2005-09-07 6:33 ` Ravikiran G Thirumalai
2005-09-06 23:42 ` [patch 3/4] ide: Break ide_lock -- change controller drivers Ravikiran G Thirumalai
2005-09-06 23:44 ` Ravikiran G Thirumalai [this message]
2005-09-07 17:06 ` [patch 4/4] ide: Break ide_lock -- remove ide_lock from piix driver Alan Cox
2005-09-07 17:50 ` Ravikiran G Thirumalai
2005-09-07 18:24 ` Alan Cox
2005-09-07 9:19 ` [patch 0/4] ide: Break ide_lock to per-hwgroup lock Jens Axboe
2005-09-07 19:27 ` Ravikiran G Thirumalai
2005-09-07 19:34 ` Jens Axboe
2005-09-27 13:36 ` Bartlomiej Zolnierkiewicz
2005-09-27 15:20 ` Ravikiran G Thirumalai
2005-09-27 15:26 ` Jens Axboe
2005-09-27 15:42 ` Ravikiran G Thirumalai
2005-09-27 15:58 ` Jens Axboe
2005-09-07 17:09 ` Alan Cox
2005-09-07 18:16 ` Ravikiran G Thirumalai
2005-09-07 19:06 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050906234429.GE3642@localhost.localdomain \
--to=kiran@scalex86.org \
--cc=alokk@calsoftinc.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shai@scalex86.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.