From: Ravikiran G Thirumalai <kiran@scalex86.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
"Shai Fultheim (Shai@scalex86.org)" <shai@scalex86.org>,
Alok Kataria <alokk@calsoftinc.com>
Subject: Re: [patch 4/4] ide: Break ide_lock -- remove ide_lock from piix driver
Date: Wed, 7 Sep 2005 10:50:19 -0700 [thread overview]
Message-ID: <20050907175019.GA3769@localhost.localdomain> (raw)
In-Reply-To: <1126112783.8928.14.camel@localhost.localdomain>
On Wed, Sep 07, 2005 at 06:06:23PM +0100, Alan Cox wrote:
> On Maw, 2005-09-06 at 16:44 -0700, Ravikiran G Thirumalai wrote:
> > Patch to convert piix driver to use per-driver/hwgroup lock and kill
> > ide_lock. In the case of piix, hwgroup->lock should be sufficient.
>
> PIIX requires that both channels are quiescent when retuning in some
> cases. It wasn't totally safe before, its now totally broken. Start by
Then the change to piix controller in my patchset is bad, How about changing
the ide_lock to per-driver lock in this case? Locking for rest of the
controllers in the system is left equivalent to what ide_lock did earlier..
> fixing the IDE layer locking properly (or forward porting my patches and
> then fixing them for all the refcounting changes and other stuff done
> since).
Can you please point me to the patchset...
Thanks,
Kiran
next prev parent reply other threads:[~2005-09-07 17:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-06 23:33 [patch 0/4] ide: Break ide_lock to per-hwgroup lock Ravikiran G Thirumalai
2005-09-06 23:37 ` [patch 1/4] ide: Break ide_lock -- Move hwif tuning code after hwif_init Ravikiran G Thirumalai
2005-09-06 23:40 ` [patch 2/4] ide: Break ide_lock -- replace ide_lock with hwgroup->lock in core ide Ravikiran G Thirumalai
2005-09-07 6:33 ` Ravikiran G Thirumalai
2005-09-06 23:42 ` [patch 3/4] ide: Break ide_lock -- change controller drivers Ravikiran G Thirumalai
2005-09-06 23:44 ` [patch 4/4] ide: Break ide_lock -- remove ide_lock from piix driver Ravikiran G Thirumalai
2005-09-07 17:06 ` Alan Cox
2005-09-07 17:50 ` Ravikiran G Thirumalai [this message]
2005-09-07 18:24 ` Alan Cox
2005-09-07 9:19 ` [patch 0/4] ide: Break ide_lock to per-hwgroup lock Jens Axboe
2005-09-07 19:27 ` Ravikiran G Thirumalai
2005-09-07 19:34 ` Jens Axboe
2005-09-27 13:36 ` Bartlomiej Zolnierkiewicz
2005-09-27 15:20 ` Ravikiran G Thirumalai
2005-09-27 15:26 ` Jens Axboe
2005-09-27 15:42 ` Ravikiran G Thirumalai
2005-09-27 15:58 ` Jens Axboe
2005-09-07 17:09 ` Alan Cox
2005-09-07 18:16 ` Ravikiran G Thirumalai
2005-09-07 19:06 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050907175019.GA3769@localhost.localdomain \
--to=kiran@scalex86.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=alokk@calsoftinc.com \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shai@scalex86.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.