From: Paul Jackson <pj@sgi.com>
To: "Jan Beulich" <JBeulich@novell.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rmmod notifier chain
Date: Fri, 9 Sep 2005 08:37:55 -0700 [thread overview]
Message-ID: <20050909083755.5ff302c3.pj@sgi.com> (raw)
In-Reply-To: <43219FDF0200007800024975@emea1-mh.id2.novell.com>
Jan wrote:
> Hence I wouldn't consider it reasonable to
> break up the debugger patch entirely and submit all the pieces at once,
> because that could easily mean that if one intermediate piece doesn't
> get accepted all the dependent pieces have been separated out
> pointlessly.
This statement sounds selfish. I read it as saying that there is
no point in doing something if it didn't result in getting your
patch accepted.
No. There is another point. At least one. Contributing to the well
being of the Linux community and kernel. That benefits us all.
A properly split and presented patch set contributes to its being
understood by others. The clearer each patch is, the more rapidly
others can understand that patch, and the faster the kernel can adapt
while remaining healthy.
If there is some good reason that some or all of your patch should not
be accepted (a reason you missed, despite your honest best efforts),
and your presentation of the patch makes it easier for someone else
to understand what you're doing and expose this reason, then be happy
- you've done your job well - assisting someone else to shoot down
your patch.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
next prev parent reply other threads:[~2005-09-09 15:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-08 15:03 [PATCH] rmmod notifier chain Jan Beulich
2005-09-08 15:11 ` Patrick McHardy
2005-09-08 15:16 ` Jan Beulich
2005-09-08 15:16 ` Christoph Hellwig
2005-09-08 15:20 ` viro
2005-09-08 15:22 ` Jan Beulich
2005-09-09 1:46 ` Andrew Morton
2005-09-09 12:44 ` Jan Beulich
2005-09-09 13:44 ` Jesper Juhl
2005-09-09 15:37 ` Paul Jackson [this message]
2005-09-09 18:27 ` Andrew Morton
2005-09-12 6:49 ` Jan Beulich
2005-09-12 7:10 ` Andrew Morton
2005-09-08 15:33 ` Tom Rini
2005-09-08 15:48 ` Jan Beulich
2005-09-09 9:42 ` [PATCH] rmmod notifier chain (attempt 2) Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050909083755.5ff302c3.pj@sgi.com \
--to=pj@sgi.com \
--cc=JBeulich@novell.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.