From: Andrew Morton <akpm@osdl.org>
To: "Jan Beulich" <JBeulich@novell.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rmmod notifier chain
Date: Mon, 12 Sep 2005 00:10:15 -0700 [thread overview]
Message-ID: <20050912001015.1a8296c7.akpm@osdl.org> (raw)
In-Reply-To: <4325412D0200007800024DE1@emea1-mh.id2.novell.com>
"Jan Beulich" <JBeulich@novell.com> wrote:
>
> >> I'd be curious to know how you, considering yourself in my
> position,
> >> would have approached breaking up and submitting that size a
> patch.
> >
> >a) Patches which affect the main kernel but which aren't really
> > debugger-related
>
> So it was right to start with those...
>
> >b) Patches which affect the main kernel and which are
> debugger-related
> > (adding hooks, generalising interfaces, refactoring functions,
> etc).
>
> ... and some of those. But you saying this was more or less the right
> approach puts things in contradiction with the complaints from others
> that consumers of some of the changes weren't immediately visible.
>
> >c) Finally, one monster patch to add the debugger functionality.
> Maybe
> > split into in vger-sized chunks.
There's confusion here between two separate concepts:
a) How patches should be presented (ie: the splitup)
b) When patches are to be merged into Linus's tree.
I have been discussing a) and you've been discussing b).
Regarding b): general cleanups/fixes/etc can of course go into Linus's tree
in the usual manner.
Preparatory patches for some large feature should be delivered as separate
patches so we can see what they're doing to the kernel but they won't
normally be merged until the same day as the large feature itself.
next prev parent reply other threads:[~2005-09-12 7:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-08 15:03 [PATCH] rmmod notifier chain Jan Beulich
2005-09-08 15:11 ` Patrick McHardy
2005-09-08 15:16 ` Jan Beulich
2005-09-08 15:16 ` Christoph Hellwig
2005-09-08 15:20 ` viro
2005-09-08 15:22 ` Jan Beulich
2005-09-09 1:46 ` Andrew Morton
2005-09-09 12:44 ` Jan Beulich
2005-09-09 13:44 ` Jesper Juhl
2005-09-09 15:37 ` Paul Jackson
2005-09-09 18:27 ` Andrew Morton
2005-09-12 6:49 ` Jan Beulich
2005-09-12 7:10 ` Andrew Morton [this message]
2005-09-08 15:33 ` Tom Rini
2005-09-08 15:48 ` Jan Beulich
2005-09-09 9:42 ` [PATCH] rmmod notifier chain (attempt 2) Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050912001015.1a8296c7.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=JBeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.