[Qemu-devel] [patch] User-mode gdbserver port number

[Qemu-devel] [patch] User-mode gdbserver port number

[Paul Brook]

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

The attached patch makes the qemu-user -g commandline option take a port 
number.

There isn't a standard port number for running gdbserver, so a single 
hardcoded value doesn't make a great deal of sense, particularly on multiuser 
machines.

Paul

[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 1834 bytes --]

Index: linux-user/main.c
===================================================================
RCS file: /cvsroot/qemu/qemu/linux-user/main.c,v
retrieving revision 1.70
diff -u -p -r1.70 main.c
--- linux-user/main.c	24 Jul 2005 18:44:56 -0000	1.70
+++ linux-user/main.c	11 Sep 2005 15:31:17 -0000
@@ -978,7 +978,7 @@ void usage(void)
            "Linux CPU emulator (compiled for %s emulation)\n"
            "\n"
            "-h           print this help\n"
-           "-g           wait gdb connection to port %d\n"
+           "-g port      wait gdb connection to port\n"
            "-L path      set the elf interpreter prefix (default=%s)\n"
            "-s size      set the stack size in bytes (default=%ld)\n"
            "\n"
@@ -989,7 +989,6 @@ void usage(void)
            "-d options   activate log (logfile=%s)\n"
            "-p pagesize  set the host page size to 'pagesize'\n",
            TARGET_ARCH,
-           DEFAULT_GDBSTUB_PORT,
            interp_prefix, 
            x86_stack_size,
            DEBUG_LOGFILE);
@@ -1013,7 +1012,7 @@ int main(int argc, char **argv)
     CPUState *env;
     int optind;
     const char *r;
-    int use_gdbstub = 0;
+    int gdbstub_port = 0;
     
     if (argc <= 1)
         usage();
@@ -1068,7 +1067,7 @@ int main(int argc, char **argv)
                 exit(1);
             }
         } else if (!strcmp(r, "g")) {
-            use_gdbstub = 1;
+            gdbstub_port = atoi(argv[optind++]);
         } else 
 #ifdef USE_CODE_COPY
         if (!strcmp(r, "no-code-copy")) {
@@ -1247,8 +1246,8 @@ int main(int argc, char **argv)
 #error unsupported target CPU
 #endif
 
-    if (use_gdbstub) {
-        gdbserver_start (DEFAULT_GDBSTUB_PORT);
+    if (gdbstub_port) {
+        gdbserver_start (gdbstub_port);
         gdb_handlesig(env, 0);
     }
     cpu_loop(env);