* lookup_nisplus module
@ 2005-09-09 20:33 Ryan Pisani
2005-09-10 3:11 ` Ian Kent
0 siblings, 1 reply; 6+ messages in thread
From: Ryan Pisani @ 2005-09-09 20:33 UTC (permalink / raw)
To: autofs
Hello -
I'm new to this list so please forgive me if I do anything out of the
norm. For the last year and a half I've been applying a fix the
lookup_nisplus.so source to allow for non-standard nisplus maps. The map
extension org_dir is hardcoded in the current and previous source as to
always assume .org_dir to any preceding map name like passwd, hosts, etc.
It occurred to me this morning that maybe I could get this changed in the
native autofs package so that I don't have to keep patching rpms for every
release of RHEL we use at work. Anyhow, I contacted Redhat and they stated
this would be the proper place to suggest a patch. Below you'll find the
patch to C source based on autofs 4.1.3. I know nisplus is probably rarely
used on Linux in most environments, but unfortunately I'm stuck with it in
mine. Please let me know if there is any way to have this patch verified,
and possibly included in future releases.
regards,
Ryan Pisani
#autofs-nisplus.patch
--- autofs-4.1.3.orig/modules/lookup_nisplus.c 2004-01-29
10:01:22.000000000 -0
600
+++ autofs-4.1.3/modules/lookup_nisplus.c 2005-06-16
13:48:26.000000000 -0
500
@@ -74,14 +74,14 @@
debug(MODPREFIX "looking up %s", name);
- sprintf(tablename, "[key=%s],%s.org_dir.%s", name, ctxt->mapname,
+ sprintf(tablename, "[key=%s],%s.%s", name, ctxt->mapname,
ctxt->domainname);
result = nis_list(tablename, FOLLOW_PATH | FOLLOW_LINKS, NULL, NULL);
if (result->status != NIS_SUCCESS && result->status !=
NIS_S_SUCCESS) {
/* Try to get the "*" entry if there is one - note that we
*don'
t*
modify "name" so & -> the name we used, not "*" */
- sprintf(tablename, "[key=*],%s.org_dir.%s", ctxt->mapname,
+ sprintf(tablename, "[key=*],%s.%s", ctxt->mapname,
ctxt->domainname);
result = nis_list(tablename, FOLLOW_PATH | FOLLOW_LINKS,
NULL, N
ULL);
}
###END PATCH
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: lookup_nisplus module
2005-09-09 20:33 lookup_nisplus module Ryan Pisani
@ 2005-09-10 3:11 ` Ian Kent
2005-09-10 3:18 ` Ryan Pisani
0 siblings, 1 reply; 6+ messages in thread
From: Ian Kent @ 2005-09-10 3:11 UTC (permalink / raw)
To: Ryan Pisani; +Cc: autofs
On Fri, 9 Sep 2005, Ryan Pisani wrote:
> Hello -
> I'm new to this list so please forgive me if I do anything out of the
> norm. For the last year and a half I've been applying a fix the
> lookup_nisplus.so source to allow for non-standard nisplus maps. The map
> extension org_dir is hardcoded in the current and previous source as to
> always assume .org_dir to any preceding map name like passwd, hosts, etc.
> It occurred to me this morning that maybe I could get this changed in the
> native autofs package so that I don't have to keep patching rpms for every
> release of RHEL we use at work. Anyhow, I contacted Redhat and they stated
> this would be the proper place to suggest a patch. Below you'll find the
> patch to C source based on autofs 4.1.3. I know nisplus is probably rarely
> used on Linux in most environments, but unfortunately I'm stuck with it in
> mine. Please let me know if there is any way to have this patch verified,
> and possibly included in future releases.
>
Hi Ryan,
Thanks for your patch.
I have to admit my maintenance of the nisplus code has been poor.
I've received a few patches over the last couple of years and haven't been
able to merge any.
Priorities, not knowing nisplus myself and the complete lack of the
ability to test has been the main problem. At one point I tried to
work with someone on this but it rapidly became too hard.
atm the priority is getting the basic functionality expected of an
automounter sorted out. Linux autofs just hasn't got it and I've been
responsible for it for quite a while now so it's way past time to get it
done.
So all I can say is I've filed it and hope to get to it.
Sorry, for now at least.
Ian
> regards,
>
> Ryan Pisani
>
>
>
> #autofs-nisplus.patch
> --- autofs-4.1.3.orig/modules/lookup_nisplus.c 2004-01-29
> 10:01:22.000000000 -0
> 600
> +++ autofs-4.1.3/modules/lookup_nisplus.c 2005-06-16
> 13:48:26.000000000 -0
> 500
> @@ -74,14 +74,14 @@
>
> debug(MODPREFIX "looking up %s", name);
>
> - sprintf(tablename, "[key=%s],%s.org_dir.%s", name, ctxt->mapname,
> + sprintf(tablename, "[key=%s],%s.%s", name, ctxt->mapname,
> ctxt->domainname);
>
> result = nis_list(tablename, FOLLOW_PATH | FOLLOW_LINKS, NULL, NULL);
> if (result->status != NIS_SUCCESS && result->status !=
> NIS_S_SUCCESS) {
> /* Try to get the "*" entry if there is one - note that we
> *don'
> t*
> modify "name" so & -> the name we used, not "*" */
> - sprintf(tablename, "[key=*],%s.org_dir.%s", ctxt->mapname,
> + sprintf(tablename, "[key=*],%s.%s", ctxt->mapname,
> ctxt->domainname);
> result = nis_list(tablename, FOLLOW_PATH | FOLLOW_LINKS,
> NULL, N
> ULL);
> }
>
> ###END PATCH
>
>
> _______________________________________________
> autofs mailing list
> autofs@linux.kernel.org
> http://linux.kernel.org/mailman/listinfo/autofs
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: lookup_nisplus module
2005-09-10 3:11 ` Ian Kent
@ 2005-09-10 3:18 ` Ryan Pisani
2005-09-10 3:36 ` Ian Kent
0 siblings, 1 reply; 6+ messages in thread
From: Ryan Pisani @ 2005-09-10 3:18 UTC (permalink / raw)
To: Ian Kent; +Cc: autofs
Thanks Ian. Hopefully it can be used down the road. If you ever do need a
tester, I'm always available, and I have access to multiple nisplus
domains that differ from the primary one. I know nisplus is not a hot item
in the world of linux and autofs. Thanks again.
Ryan
> On Fri, 9 Sep 2005, Ryan Pisani wrote:
>
>> Hello -
>> I'm new to this list so please forgive me if I do anything out of the
>> norm. For the last year and a half I've been applying a fix the
>> lookup_nisplus.so source to allow for non-standard nisplus maps. The map
>> extension org_dir is hardcoded in the current and previous source as to
>> always assume .org_dir to any preceding map name like passwd, hosts,
>> etc.
>> It occurred to me this morning that maybe I could get this changed in
>> the
>> native autofs package so that I don't have to keep patching rpms for
>> every
>> release of RHEL we use at work. Anyhow, I contacted Redhat and they
>> stated
>> this would be the proper place to suggest a patch. Below you'll find the
>> patch to C source based on autofs 4.1.3. I know nisplus is probably
>> rarely
>> used on Linux in most environments, but unfortunately I'm stuck with it
>> in
>> mine. Please let me know if there is any way to have this patch
>> verified,
>> and possibly included in future releases.
>>
>
> Hi Ryan,
>
> Thanks for your patch.
>
> I have to admit my maintenance of the nisplus code has been poor.
> I've received a few patches over the last couple of years and haven't been
> able to merge any.
>
> Priorities, not knowing nisplus myself and the complete lack of the
> ability to test has been the main problem. At one point I tried to
> work with someone on this but it rapidly became too hard.
>
> atm the priority is getting the basic functionality expected of an
> automounter sorted out. Linux autofs just hasn't got it and I've been
> responsible for it for quite a while now so it's way past time to get it
> done.
>
> So all I can say is I've filed it and hope to get to it.
>
> Sorry, for now at least.
>
> Ian
>
>> regards,
>>
>> Ryan Pisani
>>
>>
>>
>> #autofs-nisplus.patch
>> --- autofs-4.1.3.orig/modules/lookup_nisplus.c 2004-01-29
>> 10:01:22.000000000 -0
>> 600
>> +++ autofs-4.1.3/modules/lookup_nisplus.c 2005-06-16
>> 13:48:26.000000000 -0
>> 500
>> @@ -74,14 +74,14 @@
>>
>> debug(MODPREFIX "looking up %s", name);
>>
>> - sprintf(tablename, "[key=%s],%s.org_dir.%s", name,
>> ctxt->mapname,
>> + sprintf(tablename, "[key=%s],%s.%s", name, ctxt->mapname,
>> ctxt->domainname);
>>
>> result = nis_list(tablename, FOLLOW_PATH | FOLLOW_LINKS, NULL,
>> NULL);
>> if (result->status != NIS_SUCCESS && result->status !=
>> NIS_S_SUCCESS) {
>> /* Try to get the "*" entry if there is one - note that
>> we
>> *don'
>> t*
>> modify "name" so & -> the name we used, not "*" */
>> - sprintf(tablename, "[key=*],%s.org_dir.%s",
>> ctxt->mapname,
>> + sprintf(tablename, "[key=*],%s.%s", ctxt->mapname,
>> ctxt->domainname);
>> result = nis_list(tablename, FOLLOW_PATH | FOLLOW_LINKS,
>> NULL, N
>> ULL);
>> }
>>
>> ###END PATCH
>>
>>
>> _______________________________________________
>> autofs mailing list
>> autofs@linux.kernel.org
>> http://linux.kernel.org/mailman/listinfo/autofs
>>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: lookup_nisplus module
2005-09-10 3:18 ` Ryan Pisani
@ 2005-09-10 3:36 ` Ian Kent
2005-09-12 3:19 ` Peter C. Norton
0 siblings, 1 reply; 6+ messages in thread
From: Ian Kent @ 2005-09-10 3:36 UTC (permalink / raw)
To: Ryan Pisani; +Cc: autofs
On Fri, 9 Sep 2005, Ryan Pisani wrote:
> Thanks Ian. Hopefully it can be used down the road. If you ever do need a
> tester, I'm always available, and I have access to multiple nisplus
> domains that differ from the primary one. I know nisplus is not a hot item
> in the world of linux and autofs. Thanks again.
Thanks Ryan. It's in my contrib directory.
What we really need is someone that wants to do a little nisplus
development. But who has the time?
Ian
>
> Ryan
>
>
>
> > On Fri, 9 Sep 2005, Ryan Pisani wrote:
> >
> >> Hello -
> >> I'm new to this list so please forgive me if I do anything out of the
> >> norm. For the last year and a half I've been applying a fix the
> >> lookup_nisplus.so source to allow for non-standard nisplus maps. The map
> >> extension org_dir is hardcoded in the current and previous source as to
> >> always assume .org_dir to any preceding map name like passwd, hosts,
> >> etc.
> >> It occurred to me this morning that maybe I could get this changed in
> >> the
> >> native autofs package so that I don't have to keep patching rpms for
> >> every
> >> release of RHEL we use at work. Anyhow, I contacted Redhat and they
> >> stated
> >> this would be the proper place to suggest a patch. Below you'll find the
> >> patch to C source based on autofs 4.1.3. I know nisplus is probably
> >> rarely
> >> used on Linux in most environments, but unfortunately I'm stuck with it
> >> in
> >> mine. Please let me know if there is any way to have this patch
> >> verified,
> >> and possibly included in future releases.
> >>
> >
> > Hi Ryan,
> >
> > Thanks for your patch.
> >
> > I have to admit my maintenance of the nisplus code has been poor.
> > I've received a few patches over the last couple of years and haven't been
> > able to merge any.
> >
> > Priorities, not knowing nisplus myself and the complete lack of the
> > ability to test has been the main problem. At one point I tried to
> > work with someone on this but it rapidly became too hard.
> >
> > atm the priority is getting the basic functionality expected of an
> > automounter sorted out. Linux autofs just hasn't got it and I've been
> > responsible for it for quite a while now so it's way past time to get it
> > done.
> >
> > So all I can say is I've filed it and hope to get to it.
> >
> > Sorry, for now at least.
> >
> > Ian
> >
> >> regards,
> >>
> >> Ryan Pisani
> >>
> >>
> >>
> >> #autofs-nisplus.patch
> >> --- autofs-4.1.3.orig/modules/lookup_nisplus.c 2004-01-29
> >> 10:01:22.000000000 -0
> >> 600
> >> +++ autofs-4.1.3/modules/lookup_nisplus.c 2005-06-16
> >> 13:48:26.000000000 -0
> >> 500
> >> @@ -74,14 +74,14 @@
> >>
> >> debug(MODPREFIX "looking up %s", name);
> >>
> >> - sprintf(tablename, "[key=%s],%s.org_dir.%s", name,
> >> ctxt->mapname,
> >> + sprintf(tablename, "[key=%s],%s.%s", name, ctxt->mapname,
> >> ctxt->domainname);
> >>
> >> result = nis_list(tablename, FOLLOW_PATH | FOLLOW_LINKS, NULL,
> >> NULL);
> >> if (result->status != NIS_SUCCESS && result->status !=
> >> NIS_S_SUCCESS) {
> >> /* Try to get the "*" entry if there is one - note that
> >> we
> >> *don'
> >> t*
> >> modify "name" so & -> the name we used, not "*" */
> >> - sprintf(tablename, "[key=*],%s.org_dir.%s",
> >> ctxt->mapname,
> >> + sprintf(tablename, "[key=*],%s.%s", ctxt->mapname,
> >> ctxt->domainname);
> >> result = nis_list(tablename, FOLLOW_PATH | FOLLOW_LINKS,
> >> NULL, N
> >> ULL);
> >> }
> >>
> >> ###END PATCH
> >>
> >>
> >> _______________________________________________
> >> autofs mailing list
> >> autofs@linux.kernel.org
> >> http://linux.kernel.org/mailman/listinfo/autofs
> >>
> >
> >
>
>
> _______________________________________________
> autofs mailing list
> autofs@linux.kernel.org
> http://linux.kernel.org/mailman/listinfo/autofs
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: lookup_nisplus module
2005-09-10 3:36 ` Ian Kent
@ 2005-09-12 3:19 ` Peter C. Norton
0 siblings, 0 replies; 6+ messages in thread
From: Peter C. Norton @ 2005-09-12 3:19 UTC (permalink / raw)
To: Ian Kent; +Cc: autofs
On Sat, Sep 10, 2005 at 11:36:55AM +0800, Ian Kent wrote:
> On Fri, 9 Sep 2005, Ryan Pisani wrote:
>
> > Thanks Ian. Hopefully it can be used down the road. If you ever do need a
> > tester, I'm always available, and I have access to multiple nisplus
> > domains that differ from the primary one. I know nisplus is not a hot item
> > in the world of linux and autofs. Thanks again.
>
> Thanks Ryan. It's in my contrib directory.
>
> What we really need is someone that wants to do a little nisplus
> development. But who has the time?
Ian,
In general nis+ development isn't actually needed. NIS+ isn't going
anywhere and will probably be de-supported in the coming years. In the
near future, however, when x86_64 platforms with virtualization
becoming cheap and solaris x86 not being the red-headed stepchild at
sun anymore, it becomes feasible to have a NIS+ infrastructure without
needing a pile of sun boxes along with a linux client. The
infrastructure becomes the requirement for a workstation cpu and a few
dozen gigs of space on an ide drive.
Look for more action on this area next year when none of us have to
stay in the office to fix NIS+ bugs (or, more accurately, none of us
have to foobar our department NIS+ maps to test fixes).
-Peter
--
The 5 year plan:
In five years we'll make up another plan.
Or just re-use this one.
^ permalink raw reply [flat|nested] 6+ messages in thread
* lookup_nisplus module
@ 2005-09-09 20:31 Ryan Pisani
0 siblings, 0 replies; 6+ messages in thread
From: Ryan Pisani @ 2005-09-09 20:31 UTC (permalink / raw)
To: autofs
Hello -
I'm new to this list so please forgive me if I do anything out of the
norm. For the last year and a half I've been applying a fix the
lookup_nisplus.so source to allow for non-standard nisplus maps. The map
extension org_dir is hardcoded in the current and previous source as to
always assume .org_dir to any preceding map name like passwd, hosts, etc.
It occurred to me this morning that maybe I could get this changed in the
native autofs package so that I don't have to keep patching rpms for every
release of RHEL we use at work. Anyhow, I contacted Redhat and they stated
this would be the proper place to suggest a patch. Below you'll find the
patch to C source based on autofs 4.1.3. I know nisplus is probably rarely
used on Linux in most environments, but unfortunately I'm stuck with it in
mine. Please let me know if there is any way to have this patch verified,
and possibly included in future releases.
regards,
Ryan Pisani
#autofs-nisplus.patch
--- autofs-4.1.3.orig/modules/lookup_nisplus.c 2004-01-29
10:01:22.000000000 -0
600
+++ autofs-4.1.3/modules/lookup_nisplus.c 2005-06-16
13:48:26.000000000 -0
500
@@ -74,14 +74,14 @@
debug(MODPREFIX "looking up %s", name);
- sprintf(tablename, "[key=%s],%s.org_dir.%s", name, ctxt->mapname,
+ sprintf(tablename, "[key=%s],%s.%s", name, ctxt->mapname,
ctxt->domainname);
result = nis_list(tablename, FOLLOW_PATH | FOLLOW_LINKS, NULL, NULL);
if (result->status != NIS_SUCCESS && result->status !=
NIS_S_SUCCESS) {
/* Try to get the "*" entry if there is one - note that we
*don'
t*
modify "name" so & -> the name we used, not "*" */
- sprintf(tablename, "[key=*],%s.org_dir.%s", ctxt->mapname,
+ sprintf(tablename, "[key=*],%s.%s", ctxt->mapname,
ctxt->domainname);
result = nis_list(tablename, FOLLOW_PATH | FOLLOW_LINKS,
NULL, N
ULL);
}
###END PATCH
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2005-09-12 3:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-09-09 20:33 lookup_nisplus module Ryan Pisani
2005-09-10 3:11 ` Ian Kent
2005-09-10 3:18 ` Ryan Pisani
2005-09-10 3:36 ` Ian Kent
2005-09-12 3:19 ` Peter C. Norton
-- strict thread matches above, loose matches on Subject: below --
2005-09-09 20:31 Ryan Pisani
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.