From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Christoph Hellwig <hch@lst.de>,
SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 1/2] fix EH thread teardown
Date: Tue, 13 Sep 2005 19:01:26 +0200 [thread overview]
Message-ID: <200509131901.33033@bilbo.math.uni-mannheim.de> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0509131247090.4481-100000@iolanthe.rowland.org>
[-- Attachment #1: Type: text/plain, Size: 742 bytes --]
Am Dienstag, 13. September 2005 18:50 schrieb Alan Stern:
>Rolf Eike Beer wrote:
>> Ok, we looked a bit closer on all this. http://lwn.net/Articles/65178/
>> tells that ktread_stop() will not send a signal, so the
>> down_interruptible() will never return on kthread_stop(). But calling up()
>> directly before
>> kthread_stop() adds a race condition: if reschedule happens right after
>> the up() we've won nothing and it will hang again.
>
>This problem shows up in other ways as well. With hot-unpluggable
>hosts, the call that does the last 'put' on the last device will hang
>waiting for the eh thread to terminate. See
>
>http://bugzilla.kernel.org/show_bug.cgi?id=5237
Looks like someone has to build a waitqueue to fix this.
Eike
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2005-09-13 17:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-13 16:50 [PATCH 1/2] fix EH thread teardown Alan Stern
2005-09-13 17:01 ` Rolf Eike Beer [this message]
2005-09-13 19:03 ` Alan Stern
2005-09-13 19:05 ` Christoph Hellwig
2005-09-13 20:57 ` Alan Stern
2005-09-14 16:24 ` Alan Stern
-- strict thread matches above, loose matches on Subject: below --
2005-09-07 13:51 Christoph Hellwig
2005-09-07 14:01 ` Rolf Eike Beer
2005-09-08 15:26 ` Rolf Eike Beer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200509131901.33033@bilbo.math.uni-mannheim.de \
--to=eike-kernel@sf-tec.de \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.