All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Sripathi Kodi <sripathik@in.ibm.com>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, patrics@interia.pl,
	Ingo Molnar <mingo@elte.hu>, Roland McGrath <roland@redhat.com>
Subject: Re: [PATCH 2.6.13.1] Patch for invisible threads
Date: Tue, 13 Sep 2005 22:57:04 +0100	[thread overview]
Message-ID: <20050913215704.GV25261@ZenIV.linux.org.uk> (raw)
In-Reply-To: <43274503.7090303@in.ibm.com>

On Tue, Sep 13, 2005 at 04:30:43PM -0500, Sripathi Kodi wrote:
> Al Viro wrote:
> >
> >Well...  If exposing the list of tasks in a group is OK, we can just leave
> >->permission NULL for that sucker.  If it's not (and arguably it can be
> >sensitive information), we have a bigger problem - right now chroot 
> >boundary
> >is the only control we have there; normally anyone can ls 
> >/proc/<whatever>/task
> >and see other threads.
> >
> 
> Al, I understand that we can't set ->permission to NULL as it removes the 
> chroot boundary check. If I understood you correctly, we need to put 
> additional checks in proc_permission to ensure anyone doing ls 
> /proc/<pid>/task won't be able to see other threads.

Wrong.  We need a separate function, _not_ modifying proc_permssion().
If we need ->permission() at all, that is - note that anyone can do
ls /proc/<pid>/task on other users' process.

  parent reply	other threads:[~2005-09-13 21:57 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-12 17:46 [PATCH 2.6.13.1] Patch for invisible threads Sripathi Kodi
2005-09-12 20:49 ` Andrew Morton
2005-09-13 13:10   ` Sripathi Kodi
2005-09-13 14:53     ` Linus Torvalds
2005-09-13 16:51       ` Al Viro
2005-09-13 17:01         ` Linus Torvalds
2005-09-13 17:12           ` Al Viro
2005-09-13 21:30             ` Sripathi Kodi
2005-09-13 21:56               ` Roland McGrath
2005-09-13 21:57               ` Al Viro [this message]
2005-09-13 23:10               ` Linus Torvalds
2005-09-14  1:47                 ` Sripathi Kodi
2005-09-14  1:52                   ` Al Viro
2005-09-14 14:37                   ` Bill Davidsen
2005-09-15  0:30                     ` Sripathi Kodi
2005-09-14  1:50                 ` Al Viro
2005-09-15  0:31                   ` Sripathi Kodi
2005-09-15  0:55                     ` Roland McGrath
2005-09-15  1:38                       ` Sripathi Kodi
2005-09-15  2:12                         ` Al Viro
2005-09-15  7:29                           ` Roland McGrath
2005-09-15  1:18                     ` Al Viro
2005-09-16  0:54                       ` Sripathi Kodi
2005-09-16  7:46                         ` Al Viro
2005-09-16 15:06                           ` Sripathi Kodi
2005-09-16 18:05                           ` Daniel Jacobowitz
2005-09-16 18:14                             ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050913215704.GV25261@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=patrics@interia.pl \
    --cc=roland@redhat.com \
    --cc=sripathik@in.ibm.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.