ip{,6}t_random / fix build warnings.

ip{,6}t_random / fix build warnings.

[Paweł Sikora]

[-- Attachment #1: Type: text/plain, Size: 811 bytes --]

Hi,

Attached patch fixes gcc warnings:

(...)
net/ipv4/netfilter/ipt_random.c: In function `ipt_rand_checkentry':
net/ipv4/netfilter/ipt_random.c:55: warning: unsigned int format,
                                    different type arg (arg 3)

net/ipv6/netfilter/ip6t_random.c: In function `ip6t_rand_checkentry':
net/ipv6/netfilter/ip6t_random.c:58: warning: unsigned int format,
                                     different type arg (arg 3)

net/ipv6/netfilter/ip6t_random.c: At top level:
net/ipv6/netfilter/ip6t_random.c:76: warning: initialization
                                     from incompatible pointer type

Regards,
Paweł.

-- 
The only thing necessary for the triumph of evil
  is for good men to do nothing.
                                           - Edmund Burke

[-- Attachment #2: random.diff --]
[-- Type: text/x-diff, Size: 1391 bytes --]

Index: patchlets/random/linux-2.6/net/ipv4/netfilter/ipt_random.c
===================================================================
--- patchlets/random/linux-2.6/net/ipv4/netfilter/ipt_random.c	(revision 4262)
+++ patchlets/random/linux-2.6/net/ipv4/netfilter/ipt_random.c	(working copy)
@@ -52,7 +52,7 @@
 
 	if (matchsize != IPT_ALIGN(sizeof(struct ipt_rand_info))) {
 		printk("ipt_random: matchsize %u != %u\n", matchsize,
-		       IPT_ALIGN(sizeof(struct ipt_rand_info)));
+		       (unsigned)IPT_ALIGN(sizeof(struct ipt_rand_info)));
 		return 0;
 	}
 
Index: patchlets/random/linux-2.6/net/ipv6/netfilter/ip6t_random.c
===================================================================
--- patchlets/random/linux-2.6/net/ipv6/netfilter/ip6t_random.c	(revision 4262)
+++ patchlets/random/linux-2.6/net/ipv6/netfilter/ip6t_random.c	(working copy)
@@ -25,8 +25,7 @@
 	       const struct net_device *out,
 	       const void *matchinfo,
 	       int offset,
-	       const void *hdr,
-	       u_int16_t datalen,
+	       unsigned int protoff,
 	       int *hotdrop)
 {
 	/* Parameters from userspace */
@@ -55,7 +54,7 @@
 
 	if (matchsize != IP6T_ALIGN(sizeof(struct ip6t_rand_info))) {
 		printk("ip6t_random: matchsize %u != %u\n", matchsize,
-		       IP6T_ALIGN(sizeof(struct ip6t_rand_info)));
+		       (unsigned)IP6T_ALIGN(sizeof(struct ip6t_rand_info)));
 		return 0;
 	}
 

Re: ip{,6}t_random / fix build warnings.

[David S. Miller]

From: Pawe^[$,1 b^[(B Sikora <pluto@agmk.net>
Date: Sat, 17 Sep 2005 13:30:59 +0200

> Attached patch fixes gcc warnings:
> 

Don't cast the value, use the correct "%Zu" and "%Zd"
size_t printf format strings instead as that's what the
compiler is warning about.

Re: ip{,6}t_random / fix build warnings.

[Harald Welte]

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]

On Sat, Sep 17, 2005 at 01:30:59PM +0200, Paweł Sikora wrote:
> Hi,
> 
> Attached patch fixes gcc warnings:

Applied with modifications (use %Zd).
-- 
- Harald Welte <laforge@netfilter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]