From: Greg KH <greg@kroah.com>
To: dmitry pervushin <dpervushin@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
spi-devel-general@lists.sourceforge.net
Subject: Re: SPI
Date: Tue, 27 Sep 2005 05:43:35 -0700 [thread overview]
Message-ID: <20050927124335.GA10361@kroah.com> (raw)
In-Reply-To: <1127733134.7577.0.camel@diimka.dev.rtsoft.ru>
On Mon, Sep 26, 2005 at 03:12:14PM +0400, dmitry pervushin wrote:
> +/*
> + * spi_device_release
> + *
> + * Pointer to this function will be put to dev->release place
> + * This function gets called as a part of device removing
> + *
> + * Parameters:
> + * struct device* dev
> + * Return value:
> + * none
> + */
> +void spi_device_release( struct device* dev )
> +{
> +/* just a placeholder */
> +}
This is ALWAYS wrong, please fix your code. See the many times I have
been over this issue in the archives.
Also, please fix your coding style to match the kernel if you wish to
have a chance to get it included. :)
thanks,
greg k-h
next prev parent reply other threads:[~2005-09-27 12:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-26 11:12 SPI dmitry pervushin
2005-09-26 12:31 ` SPI Eric Piel
2005-09-26 12:37 ` [spi-devel-general] SPI dmitry pervushin
2005-09-26 16:20 ` SPI Grant Likely
2005-09-27 7:39 ` [spi-devel-general] SPI dmitry pervushin
2005-09-26 16:25 ` SPI Valdis.Kletnieks
2005-09-26 16:46 ` [spi-devel-general] SPI Vitaly Wool
2005-09-26 20:25 ` SPI Jesper Juhl
2005-09-27 12:43 ` Greg KH [this message]
2005-09-27 14:27 ` [spi-devel-general] SPI dmitry pervushin
2005-09-27 14:35 ` Greg KH
2005-09-27 14:49 ` dmitry pervushin
2005-09-27 14:54 ` Greg KH
2005-09-27 15:19 ` dmitry pervushin
2005-09-28 13:14 ` [PATCH] SPI dmitry pervushin
-- strict thread matches above, loose matches on Subject: below --
2022-06-09 10:52 SPI Davide Valeri
2022-06-09 11:50 ` SPI Philippe Gerum
2022-06-15 13:53 ` SPI Davide Valeri
2005-11-11 10:11 SPI dmitry pervushin
2005-11-21 20:15 ` SPI Mark Underwood
2005-11-21 20:56 ` SPI Vitaly Wool
2005-11-21 21:23 ` SPI Mark Underwood
2005-11-21 21:27 ` SPI David Brownell
2005-05-31 20:31 SPI Garst R. Reese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050927124335.GA10361@kroah.com \
--to=greg@kroah.com \
--cc=dpervushin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.