All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Wool <vwool@ru.mvista.com>
To: Valdis.Kletnieks@vt.edu
Cc: dmitry pervushin <dpervushin@gmail.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	spi-devel-general@lists.sourceforge.net
Subject: Re: [spi-devel-general] Re: SPI
Date: Mon, 26 Sep 2005 20:46:52 +0400	[thread overview]
Message-ID: <433825FC.7050603@ru.mvista.com> (raw)
In-Reply-To: <200509261625.j8QGPQ9K007078@turing-police.cc.vt.edu>

My POV is that those lines should go away.

Best regards,
   Vitaly

Valdis.Kletnieks@vt.edu wrote:

>On Mon, 26 Sep 2005 15:12:14 +0400, dmitry pervushin said:
>  
>
>>Hello guys,
>>
>>I am attaching the next incarnation of SPI core; feel free to comment it.
>>    
>>
>
>  
>
>>+/* The devfs code is contributed by Philipp Matthias Hahn 
>>+   <pmhahn@titan.lahn.de> */
>>    
>>
>
>  
>
>>+/* devfs code corrected to support automatic device addition/deletion
>>+   by Vitaly Wool <vwool@ru.mvista.com> (C) 2004 MontaVista Software, Inc. 
>>+ */
>>    
>>
>
>I'd like to thank Vitaly and Philipp for their work, which was probably useful
>at the time, but I've always wondered - when cleaning up code, should such comments
>be removed too, or left as historical reminders?  The MAINTAINERS file seems
>to get cleaned most of the time, the CREDITS doesn't - which way should
>in-source comments go?
>
>  
>


  reply	other threads:[~2005-09-26 16:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-26 11:12 SPI dmitry pervushin
2005-09-26 12:31 ` SPI Eric Piel
2005-09-26 12:37   ` [spi-devel-general] SPI dmitry pervushin
2005-09-26 16:20 ` SPI Grant Likely
2005-09-27  7:39   ` [spi-devel-general] SPI dmitry pervushin
2005-09-26 16:25 ` SPI Valdis.Kletnieks
2005-09-26 16:46   ` Vitaly Wool [this message]
2005-09-26 20:25 ` SPI Jesper Juhl
2005-09-27 12:43 ` SPI Greg KH
2005-09-27 14:27   ` [spi-devel-general] SPI dmitry pervushin
2005-09-27 14:35     ` Greg KH
2005-09-27 14:49       ` dmitry pervushin
2005-09-27 14:54         ` Greg KH
2005-09-27 15:19           ` dmitry pervushin
2005-09-28 13:14           ` [PATCH] SPI dmitry pervushin
  -- strict thread matches above, loose matches on Subject: below --
2005-11-21 20:15 SPI Mark Underwood
2005-11-21 21:27 ` SPI David Brownell
2005-11-22  6:00   ` [spi-devel-general] SPI Vitaly Wool
2005-11-22 19:11     ` Mark Underwood
     [not found]       ` <200511221233.16634.david-b@pacbell.net>
2005-11-23  9:33         ` Vitaly Wool
2005-11-23 19:05           ` David Brownell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=433825FC.7050603@ru.mvista.com \
    --to=vwool@ru.mvista.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=dpervushin@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spi-devel-general@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.