From: Al Viro <viro@ftp.linux.org.uk>
To: Borislav Petkov <bbpetkov@yahoo.de>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, R.E.Wolff@BitWizard.nl
Subject: Re: [PATCH] remove check_region in drivers-char-specialix.c
Date: Wed, 28 Sep 2005 18:52:44 +0100 [thread overview]
Message-ID: <20050928175244.GY7992@ftp.linux.org.uk> (raw)
In-Reply-To: <20050928083737.GA29498@gollum.tnic>
On Wed, Sep 28, 2005 at 10:37:37AM +0200, Borislav Petkov wrote:
> Hi Andrew,
>
> This is also a pretty simple case. We remove the wrapper and make
> sx__request_io_range return struct resource *. We check its value accordingly
> in the probing routine. It compiles cleanly here.
NAK. You've just introduced a pile of leaks - if sx_probe() fails after
that call, you end up with region claimed and not released.
next prev parent reply other threads:[~2005-09-28 17:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-28 8:37 [PATCH] remove check_region in drivers-char-specialix.c Borislav Petkov
2005-09-28 17:52 ` Al Viro [this message]
2005-09-28 22:28 ` Borislav Petkov
2005-09-29 1:10 ` Al Viro
2005-09-29 1:41 ` Andrew Morton
2005-09-29 2:05 ` Al Viro
2005-09-29 6:43 ` Rogier Wolff
2005-09-29 7:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050928175244.GY7992@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=R.E.Wolff@BitWizard.nl \
--cc=akpm@osdl.org \
--cc=bbpetkov@yahoo.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.