From: Al Viro <viro@ftp.linux.org.uk>
To: Borislav Petkov <bbpetkov@yahoo.de>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, R.E.Wolff@BitWizard.nl
Subject: Re: [PATCH] remove check_region in drivers-char-specialix.c
Date: Thu, 29 Sep 2005 02:10:26 +0100 [thread overview]
Message-ID: <20050929011026.GO7992@ftp.linux.org.uk> (raw)
In-Reply-To: <20050928222822.GA14949@gollum.tnic>
On Thu, Sep 29, 2005 at 12:28:22AM +0200, Borislav Petkov wrote:
> Andrew told me already today that Jeff[1] had sent a patch fixing all that. To
> prevent the leaks he's calling sx_release_io_range(bp) in every check before
> exiting sx_probe so this seems correct. A small question though: After calling
> sx_request_io_range() in the if-statement on line 499 is it ok to call
> sx_request_io_range() for a second time in a row on line 587? I think in
> this case the second call has to go, no?
>
> [1]rsync://rsync.kernel.org/pub/scm/linux/kernel/git/jgarzik/misc-2.6.git
Huh? I don't see any specialix patches in that repository right now...
But yes, after successful request_region() you shouldn't call it again -
that would simply fail.
next prev parent reply other threads:[~2005-09-29 1:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-28 8:37 [PATCH] remove check_region in drivers-char-specialix.c Borislav Petkov
2005-09-28 17:52 ` Al Viro
2005-09-28 22:28 ` Borislav Petkov
2005-09-29 1:10 ` Al Viro [this message]
2005-09-29 1:41 ` Andrew Morton
2005-09-29 2:05 ` Al Viro
2005-09-29 6:43 ` Rogier Wolff
2005-09-29 7:38 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050929011026.GO7992@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=R.E.Wolff@BitWizard.nl \
--cc=akpm@osdl.org \
--cc=bbpetkov@yahoo.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.