From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Deepak Saxena <dsaxena@plexity.net>
Cc: Linus Torvalds <torvalds@osdl.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix IXP4xx MTD driver no cast warning
Date: Thu, 29 Sep 2005 21:52:52 +0100 [thread overview]
Message-ID: <20050929205252.GG7684@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20050929195205.GA30002@plexity.net>
On Thu, Sep 29, 2005 at 12:52:05PM -0700, Deepak Saxena wrote:
> Fix following warning:
>
> drivers/mtd/maps/ixp4xx.c: In function 'ixp4xx_flash_probe':
> drivers/mtd/maps/ixp4xx.c:199: warning: assignment makes integer from
> pointer without a cast
>
> Signed-off-by: Deepak Saxena <dsaxena@plexity.net>
>
> diff --git a/drivers/mtd/maps/ixp4xx.c b/drivers/mtd/maps/ixp4xx.c
> --- a/drivers/mtd/maps/ixp4xx.c
> +++ b/drivers/mtd/maps/ixp4xx.c
> @@ -196,7 +196,7 @@ static int ixp4xx_flash_probe(struct dev
> goto Error;
> }
>
> - info->map.map_priv_1 = ioremap(dev->resource->start,
> + info->map.map_priv_1 = (unsigned long)ioremap(dev->resource->start,
Shouldn't this be using info->map.virt instead of the old map.map_priv_1 ?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
WARNING: multiple messages have this Message-ID (diff)
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Deepak Saxena <dsaxena@plexity.net>
Cc: Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH] Fix IXP4xx MTD driver no cast warning
Date: Thu, 29 Sep 2005 21:52:52 +0100 [thread overview]
Message-ID: <20050929205252.GG7684@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20050929195205.GA30002@plexity.net>
On Thu, Sep 29, 2005 at 12:52:05PM -0700, Deepak Saxena wrote:
> Fix following warning:
>
> drivers/mtd/maps/ixp4xx.c: In function 'ixp4xx_flash_probe':
> drivers/mtd/maps/ixp4xx.c:199: warning: assignment makes integer from
> pointer without a cast
>
> Signed-off-by: Deepak Saxena <dsaxena@plexity.net>
>
> diff --git a/drivers/mtd/maps/ixp4xx.c b/drivers/mtd/maps/ixp4xx.c
> --- a/drivers/mtd/maps/ixp4xx.c
> +++ b/drivers/mtd/maps/ixp4xx.c
> @@ -196,7 +196,7 @@ static int ixp4xx_flash_probe(struct dev
> goto Error;
> }
>
> - info->map.map_priv_1 = ioremap(dev->resource->start,
> + info->map.map_priv_1 = (unsigned long)ioremap(dev->resource->start,
Shouldn't this be using info->map.virt instead of the old map.map_priv_1 ?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-09-29 20:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-29 19:52 [PATCH] Fix IXP4xx MTD driver no cast warning Deepak Saxena
2005-09-29 19:52 ` Deepak Saxena
2005-09-29 20:00 ` Linus Torvalds
2005-09-29 20:00 ` Linus Torvalds
2005-09-29 23:02 ` Jörn Engel
2005-09-29 23:02 ` Jörn Engel
2005-09-29 20:52 ` Russell King [this message]
2005-09-29 20:52 ` Russell King
2005-09-29 21:20 ` Deepak Saxena
2005-09-29 21:20 ` Deepak Saxena
2005-09-29 23:18 ` Jörn Engel
2005-09-29 23:18 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050929205252.GG7684@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=dsaxena@plexity.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.