[KJ] [PATCH] kernel/audit.c char *foo="bar" -> char foo[]="bar"

[KJ] [PATCH] kernel/audit.c char *foo="bar" -> char foo[]="bar"

[Masoud Sharbiani]

[-- Attachment #1: Type: text/plain, Size: 545 bytes --]

Hello, 
The patch below, converts the only instance of char *foo="constant" to char *foo[]="constant"
cheers, 
Masoud

Signed-off-by: Masoud A Sharbiani <masouds@masoud.ir>

diff --git a/kernel/audit.c b/kernel/audit.c
--- a/kernel/audit.c
+++ b/kernel/audit.c
@@ -787,7 +787,7 @@ void audit_log_hex(struct audit_buffer *
 	int i, avail, new_len;
 	unsigned char *ptr;
 	struct sk_buff *skb;
-	static const unsigned char *hex = "0123456789ABCDEF";
+	static const unsigned char hex[] = "0123456789ABCDEF";
 
 	BUG_ON(!ab->skb);
 	skb = ab->skb;


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] kernel/audit.c char *foo="bar" -> char foo[]="bar"

[Alexey Dobriyan]

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

On Tue, Oct 04, 2005 at 03:20:32PM -0400, Masoud Sharbiani wrote:
> The patch below, converts the only instance of char *foo="constant"
> to char *foo[]="constant"

All gccs here agreed that the size of kernel/audit.o will become
smaller. Applied.

> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -787,7 +787,7 @@ void audit_log_hex(struct audit_buffer *

> -	static const unsigned char *hex = "0123456789ABCDEF";
> +	static const unsigned char hex[] = "0123456789ABCDEF";


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors