From: Ingo Molnar <mingo@elte.hu>
To: Dominik Brodowski <linux@dominikbrodowski.net>
Cc: Mark Knecht <markknecht@gmail.com>,
linux-kernel@vger.kernel.org, linux-pcmcia@lists.infradead.org,
Steven Rostedt <rostedt@goodmis.org>
Subject: [patch] pcmcia-shutdown-fix.patch
Date: Fri, 7 Oct 2005 13:09:14 +0200 [thread overview]
Message-ID: <20051007110914.GA30873@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.58.0510061308290.973@localhost.localdomain>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> Ingo, here's the patch. This should probably go upstream too since it
> can happen there too. The pccardd thread has a race in it that it can
> shutdown in the TASK_INTERRUPTIBLE state. Here's the fix.
ah, certainly makes sense. Dominik, does it look good to you too? Patch
below is for upstream.
Ingo
----
The pccardd thread has a race in it that it can shutdown in the
TASK_INTERRUPTIBLE state. Found on the -rt kernel.
From: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
--
drivers/pcmcia/cs.c | 3 +++
1 files changed, 3 insertions(+)
Index: linux/drivers/pcmcia/cs.c
===================================================================
--- linux.orig/drivers/pcmcia/cs.c
+++ linux/drivers/pcmcia/cs.c
@@ -689,6 +689,9 @@ static int pccardd(void *__skt)
schedule();
try_to_freeze();
}
+ /* make sure we are running before we exit */
+ set_current_state(TASK_RUNNING);
+
remove_wait_queue(&skt->thread_wait, &wait);
/* remove from the device core */
next prev parent reply other threads:[~2005-10-07 11:08 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-13 10:00 2.6.13-rt6, ktimer subsystem Ingo Molnar
2005-09-13 19:59 ` Lee Revell
2005-09-13 20:06 ` Lee Revell
2005-09-13 20:10 ` Ingo Molnar
2005-09-13 20:36 ` Lee Revell
2005-09-15 7:55 ` Ingo Molnar
2005-09-15 11:37 ` Ingo Molnar
2005-09-14 15:56 ` Darren Hart
2005-09-14 22:09 ` Darren Hart
2005-09-14 19:38 ` George Anzinger
2005-09-15 2:25 ` Thomas Gleixner
2005-09-15 22:35 ` George Anzinger
2005-09-15 22:53 ` Thomas Gleixner
2005-09-15 23:10 ` George Anzinger
2005-09-15 23:09 ` Daniel Walker
2005-09-16 0:08 ` George Anzinger
2005-09-15 9:20 ` Ingo Molnar
2005-09-15 23:04 ` George Anzinger
2005-09-15 23:20 ` Thomas Gleixner
2005-09-15 9:43 ` Roman Zippel
2005-09-26 7:02 ` 2.6.14-rc2-rt2 Ingo Molnar
2005-09-27 6:13 ` 2.6.14-rc2-rt2 Eran Mann
2005-09-27 10:33 ` 2.6.14-rc2-rt2 Ingo Molnar
2005-09-27 16:59 ` 2.6.14-rc2-rt2 Fernando Lopez-Lezcano
2005-09-27 22:15 ` 2.6.14-rc2-rt2 Thomas Gleixner
2005-09-27 23:11 ` 2.6.14-rc2-rt2 Fernando Lopez-Lezcano
2005-09-27 23:10 ` 2.6.14-rc2-rt2 Daniel Walker
2005-09-28 3:04 ` 2.6.14-rc2-rt2 Fernando Lopez-Lezcano
2005-09-28 9:48 ` 2.6.14-rc2-rt2 Ingo Molnar
2005-09-28 16:34 ` 2.6.14-rc2-rt2 Fernando Lopez-Lezcano
2005-09-29 9:07 ` 2.6.14-rc2-rt2 Eran Mann
2005-09-28 9:10 ` 2.6.14-rc2-rt2 Peter Zijlstra
2005-09-29 16:45 ` 2.6.14-rc2-rt2 Badari Pulavarty
2005-09-30 10:58 ` 2.6.14-rc2-rt2 Ingo Molnar
2005-10-02 15:18 ` 2.6.14-rc3-rt1 Ingo Molnar
2005-10-02 15:42 ` 2.6.14-rc3-rt1 Mark Knecht
2005-10-02 19:25 ` 2.6.14-rc3-rt1 Mark Knecht
2005-10-06 17:13 ` 2.6.14-rc3-rt1 Steven Rostedt
2005-10-07 11:09 ` Ingo Molnar [this message]
2005-10-07 19:17 ` [patch] pcmcia-shutdown-fix.patch Russell King
2005-10-07 19:46 ` Steven Rostedt
2005-10-10 15:13 ` Steven Rostedt
2005-10-10 15:37 ` Steven Rostedt
2005-10-02 20:51 ` 2.6.14-rc3-rt1 Felix Oxley
2005-10-02 21:55 ` 2.6.14-rc3-rt1 Felix Oxley
2005-10-03 6:33 ` 2.6.14-rc3-rt1 Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051007110914.GA30873@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
--cc=linux@dominikbrodowski.net \
--cc=markknecht@gmail.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.