Re: 2.6.14-rc2-rt2

[emann@mrv.com (Eran Mann)]

[-- Attachment #1: Type: text/plain, Size: 1490 bytes --]


Fernando Lopez-Lezcano wrote:
>>could you try 2.6.14-rc2-rt6, does it build?
> 
> 
> No, sorry...
> 
> fs/ntfs/aops.c: In function 'ntfs_end_buffer_async_read':
> fs/ntfs/aops.c:108: error: 'BH_Uptodate_Lock' undeclared (first use in
> this function)
> fs/ntfs/aops.c:108: error: (Each undeclared identifier is reported only
> once
> fs/ntfs/aops.c:108: error: for each function it appears in.)
> make[2]: *** [fs/ntfs/aops.o] Error 1
> 
> and (probably unrelated to rt):
> 
> drivers/isdn/hisax/config.c: In function 'HiSax_readstatus':
> drivers/isdn/hisax/config.c:636: warning: ignoring return value of
> 'copy_to_user', declared with attribute warn_unused_result
> drivers/isdn/hisax/config.c:647: warning: ignoring return value of
> 'copy_to_user', declared with attribute warn_unused_result
> drivers/isdn/hisax/callc.c: In function 'HiSax_writebuf_skb':
> drivers/isdn/hisax/callc.c:1781: warning: large integer implicitly
> truncated to unsigned type
> drivers/isdn/hisax/st5481_usb.c: In function 'st5481_in_mode':
> drivers/isdn/hisax/st5481_usb.c:648: error: 'URB_ASYNC_UNLINK'
> undeclared (first use in this function)
> drivers/isdn/hisax/st5481_usb.c:648: error: (Each undeclared identifier
> is reported only once
> drivers/isdn/hisax/st5481_usb.c:648: error: for each function it appears
> in.)
> make[3]: *** [drivers/isdn/hisax/st5481_usb.o] Error 1
> 
> -- Fernando
> 
> 
Regarding NTFS - try with the attached patch. It seems to be still 
missing from 2.6.14-rc2-rt7.

[-- Attachment #2: linux-rt-ntfs.patch --]
[-- Type: text/x-patch, Size: 994 bytes --]

--- fs/ntfs/aops.c.old	2005-09-25 16:20:26.000000000 +0300
+++ fs/ntfs/aops.c	2005-09-25 16:22:04.000000000 +0300
@@ -104,8 +104,7 @@
 				"0x%llx.", (unsigned long long)bh->b_blocknr);
 	}
 	first = page_buffers(page);
-	local_irq_save(flags);
-	bit_spin_lock(BH_Uptodate_Lock, &first->b_state);
+	spin_lock_irqsave(&first->b_uptodate_lock, flags);
 	clear_buffer_async_read(bh);
 	unlock_buffer(bh);
 	tmp = bh;
@@ -120,8 +119,7 @@
 		}
 		tmp = tmp->b_this_page;
 	} while (tmp != bh);
-	bit_spin_unlock(BH_Uptodate_Lock, &first->b_state);
-	local_irq_restore(flags);
+	spin_unlock_irqrestore(&first->b_uptodate_lock, flags);
 	/*
 	 * If none of the buffers had errors then we can set the page uptodate,
 	 * but we first have to perform the post read mst fixups, if the
@@ -154,8 +152,7 @@
 	unlock_page(page);
 	return;
 still_busy:
-	bit_spin_unlock(BH_Uptodate_Lock, &first->b_state);
-	local_irq_restore(flags);
+	spin_unlock_irqrestore(&first->b_uptodate_lock, flags);
 	return;
 }