[KJ] rfc about an uncommented string

[KJ] rfc about an uncommented string

[Carlo Perassi]

[-- Attachment #1: Type: text/plain, Size: 568 bytes --]

Hi.

I'd like to collect some comments about the following code
segment I found in
linux-2.6.13-rc6/arch/mips/ite-boards/generic/it8172_setup.c
(the "^^^" sequence is not mine, it's in the code)

#ifdef CONFIG_SERIO_I8042
/*
 * According to the ITE Special BIOS Note for waking up the
 * keyboard controller...
 */
static int init_8712_keyboard(void)
{
	unsigned int cmd_port = 0x14000064;
	unsigned int data_port = 0x14000060;
	                         ^^^^^^^^^^^
	Somebody here doesn't grok the concept of io ports.

-- 
Carlo Perassi - http://www.linux.it/~carlo/

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] rfc about an uncommented string

[walter harms]

this will break if CONFIG_SERIO_I8042 is set and i guess intentionaly.

who checked that in ?  perhaps the mips ppl know about it.

re,
	walter


Carlo Perassi wrote:
> Hi.
> 
> I'd like to collect some comments about the following code
> segment I found in
> linux-2.6.13-rc6/arch/mips/ite-boards/generic/it8172_setup.c
> (the "^^^" sequence is not mine, it's in the code)
> 
> #ifdef CONFIG_SERIO_I8042
> /*
>  * According to the ITE Special BIOS Note for waking up the
>  * keyboard controller...
>  */
> static int init_8172_keyboard(void)
> {
> 	unsigned int cmd_port = 0x14000064;
> 	unsigned int data_port = 0x14000060;
> 	                         ^^^^^^^^^^^
> 	Somebody here doesn't grok the concept of io ports.
> 
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Kernel-janitors mailing list
> Kernel-janitors@lists.osdl.org
> https://lists.osdl.org/mailman/listinfo/kernel-janitors
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] rfc about an uncommented string

[Carlo Perassi]

> this will break if CONFIG_SERIO_I8042 is set and i guess intentionaly.

I think so but I guess it is not the standard way to let the user know
CONFIG_SERIO_I8042 is broken.

> who checked that in ?  perhaps the mips ppl know about it.

What do you suggest to do?
Thank you.

-- 
Carlo Perassi - http://www.linux.it/~carlo/

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] rfc about an uncommented string

[Arthur Othieno]

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

On Tue, Aug 09, 2005 at 07:51:21PM +0200, Carlo Perassi wrote:
> > this will break if CONFIG_SERIO_I8042 is set and i guess intentionaly.
> 
> I think so but I guess it is not the standard way to let the user know
> CONFIG_SERIO_I8042 is broken.
> 
> > who checked that in ?  perhaps the mips ppl know about it.
> 
> What do you suggest to do?
> Thank you.

Bounce it to <linux-mips@linux-mips.org>? The delta between the mainline
and linux-mips git trees is quite huge, and that particular piece of code
is still present in both..

	Arthur

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors