From: a.othieno@bluewin.ch (Arthur Othieno)
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] Remove select_bits_alloc(), select_bits_free()
Date: Sat, 08 Oct 2005 22:16:33 +0000 [thread overview]
Message-ID: <20051008221633.GA10443@mars> (raw)
In-Reply-To: <20051006152016.GA21578@mipter.zuzino.mipt.ru>
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
On Sun, Oct 09, 2005 at 02:17:06AM +0400, Alexey Dobriyan wrote:
> On Fri, Oct 07, 2005 at 06:59:11PM -0400, Arthur Othieno wrote:
> > On Thu, Oct 06, 2005 at 07:20:16PM +0400, Alexey Dobriyan wrote:
> > > * Both are trivial wrappers.
> > > * Each wrapper is used only in one place.
> >
> > These managed to stay under you radar :)
>
> Heh... Who greps for static functions? ;-)
>
> > fs/compat.c:1597:static void *select_bits_alloc(int size)
> > fs/compat.c:1602:static void select_bits_free(void *bits, int size)
> > fs/compat.c:1666: bits = select_bits_alloc(size);
> > fs/compat.c:1712: select_bits_free(bits, size);
>
> So, 2 ways: remove all, consolidate. Opinions?
As you noted earlier, these are pretty much redundant (across both
fs/{compat,select}.c). Removing all would be a better cleanup, no?
Arthur
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2005-10-08 22:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-06 15:20 [KJ] [PATCH] Remove select_bits_alloc(), select_bits_free() Alexey Dobriyan
2005-10-07 22:59 ` Arthur Othieno
2005-10-08 22:16 ` Arthur Othieno [this message]
2005-10-08 22:17 ` Alexey Dobriyan
2005-10-08 23:26 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051008221633.GA10443@mars \
--to=a.othieno@bluewin.ch \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.