From: "David S. Miller" <davem@davemloft.net>
To: laforge@gnumonks.org
Cc: netfilter-devel@lists.netfilter.org
Subject: Re: [PATCH 1/5] NETFILTER ctnetlink: use ENOMEM instead of -1
Date: Sun, 09 Oct 2005 21:39:05 -0700 (PDT) [thread overview]
Message-ID: <20051009.213905.47127482.davem@davemloft.net> (raw)
In-Reply-To: <20051007221948.GL4450@rama.customers.eurospot.com>
From: Harald Welte <laforge@gnumonks.org>
Date: Sat, 8 Oct 2005 00:19:48 +0200
> [NETFILTER] ctnetlink: use ENOMEM instead of -1 (-ENOPERM)
>
> Fix the return value of NFA_PUT on fail. Now it returns -ENOMEM
> instead of -1 (-ENOPERM) since NFA_PUT only fails if there's no
> enough space in the netlink message for the new attribute that
> will be added. Thanks to Patrick McHardy for spotting this.
>
> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
> Signed-off-by: Harald Welte <laforge@netfilter.org>
Applied for 2.6.14, thanks.
prev parent reply other threads:[~2005-10-10 4:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-07 22:19 [PATCH 1/5] NETFILTER ctnetlink: use ENOMEM instead of -1 Harald Welte
2005-10-08 15:42 ` Patrick McHardy
2005-10-10 4:52 ` David S. Miller
2005-10-10 8:44 ` Harald Welte
2005-10-10 4:39 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051009.213905.47127482.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=laforge@gnumonks.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.