Re: [PATCH 1/5] NETFILTER ctnetlink: use ENOMEM instead of -1

[Patrick McHardy <kaber@trash.net>]

Harald Welte wrote:
> [NETFILTER] ctnetlink: use ENOMEM instead of -1 (-ENOPERM)
> 
> Fix the return value of NFA_PUT on fail. Now it returns -ENOMEM
> instead of -1 (-ENOPERM) since NFA_PUT only fails if there's no
> enough space in the netlink message for the new attribute that
> will be added. Thanks to Patrick McHardy for spotting this.

Actually this is not what I meant. On paths were NFA_PUT is used,
returning -1 is fine because the caller just checks for <0 to
notice an error and the error is not returned to userspace or
something. -ENOMEM is obviously wrong since there is no memory
allocation involved. What I meant was to not return -1 on
the receive path, where NFA_PUT isn't used, but to propagate
the real error from the function call before (I don't remember
which one it was).

Dave, please drop this patch.