From: a.othieno@bluewin.ch (Arthur Othieno)
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] printk : kernel/softirq.c
Date: Sun, 09 Oct 2005 13:22:48 +0000 [thread overview]
Message-ID: <20051009132248.GA3710@mars> (raw)
In-Reply-To: <03ca01c5cb00$c020f0f0$5f051aac@pcp42831>
[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]
On Fri, Oct 07, 2005 at 11:04:12AM +0530, Milind A Choudhary(Patni) wrote:
> Description:
> printk() calls should include appropriate KERN_* constant.
>
> Signed-off-by: Milind A Choudhary <milind.choudhary@patni.com>
>
> The patch
> Index: linux-2.6.14-rc3/kernel/softirq.c
> ===================================================================
> --- linux-2.6.14-rc3.orig/kernel/softirq.c 2005-10-06 15:30:37.000000000 +0530
> +++ linux-2.6.14-rc3/kernel/softirq.c 2005-10-06 18:59:24.000000000 +0530
> @@ -328,7 +328,7 @@ EXPORT_SYMBOL(tasklet_init);
> void tasklet_kill(struct tasklet_struct *t)
> {
> if (in_interrupt())
> - printk("Attempt to kill tasklet from interrupt\n");
> + printk(KERN_ERR "Attempt to kill tasklet from interrupt\n");
KERN_ERR is usually on the error path, which isn't the case here. As
this is just a warning, KERN_WARNING would be more appropriate here, no?
> while (test_and_set_bit(TASKLET_STATE_SCHED, &t->state)) {
> do
> @@ -458,7 +458,7 @@ static int __devinit cpu_callback(struct
> BUG_ON(per_cpu(tasklet_hi_vec, hotcpu).list);
> p = kthread_create(ksoftirqd, hcpu, "ksoftirqd/%d", hotcpu);
> if (IS_ERR(p)) {
> - printk("ksoftirqd for %i failed\n", hotcpu);
> + printk(KERN_ERR "ksoftirqd for %i failed\n", hotcpu);
> return NOTIFY_BAD;
> }
> kthread_bind(p, hotcpu);
>
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
prev parent reply other threads:[~2005-10-09 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-07 5:46 [KJ] [PATCH] printk : kernel/softirq.c Milind A Choudhary(Patni)
2005-10-07 9:56 ` Christophe Lucas
2005-10-07 10:53 ` Milind A Choudhary(Patni)
2005-10-07 10:54 ` Christophe Lucas
2005-10-09 13:22 ` Arthur Othieno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051009132248.GA3710@mars \
--to=a.othieno@bluewin.ch \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.