[KJ] [PATCH] printk : kernel/softirq.c

[KJ] [PATCH] printk : kernel/softirq.c

[Milind A Choudhary(Patni)]

[-- Attachment #1: Type: text/plain, Size: 2132 bytes --]

Description:
printk() calls should include appropriate KERN_* constant.

Signed-off-by: Milind A Choudhary <milind.choudhary@patni.com>

The patch
Index: linux-2.6.14-rc3/kernel/softirq.c
===================================================================
--- linux-2.6.14-rc3.orig/kernel/softirq.c	2005-10-06 15:30:37.000000000 +0530
+++ linux-2.6.14-rc3/kernel/softirq.c	2005-10-06 18:59:24.000000000 +0530
@@ -328,7 +328,7 @@ EXPORT_SYMBOL(tasklet_init);
 void tasklet_kill(struct tasklet_struct *t)
 {
 	if (in_interrupt())
-		printk("Attempt to kill tasklet from interrupt\n");
+		printk(KERN_ERR "Attempt to kill tasklet from interrupt\n");
 
 	while (test_and_set_bit(TASKLET_STATE_SCHED, &t->state)) {
 		do
@@ -458,7 +458,7 @@ static int __devinit cpu_callback(struct
 		BUG_ON(per_cpu(tasklet_hi_vec, hotcpu).list);
 		p = kthread_create(ksoftirqd, hcpu, "ksoftirqd/%d", hotcpu);
 		if (IS_ERR(p)) {
-			printk("ksoftirqd for %i failed\n", hotcpu);
+			printk(KERN_ERR "ksoftirqd for %i failed\n", hotcpu);
 			return NOTIFY_BAD;
 		}
 		kthread_bind(p, hotcpu);

===================================================================
apologies for the disclaimer...I'll fix it soon..
how do I come to know whether my patches are being accepted?
kindly let me know..

Thanks & Regards
Milind A Choudhary 
http://www.patni.com
World-Wide Partnerships. World-Class Solutions.
_____________________________________________________________________

This e-mail message may contain proprietary, confidential or legally
privileged information for the sole use of the person or entity to
whom this message was originally addressed. Any review, e-transmission
dissemination or other use of or taking of any action in reliance upon
this information by persons or entities other than the intended
recipient is prohibited. If you have received this e-mail in error
kindly delete  this e-mail from your records. If it appears that this
mail has been forwarded to you without proper authority, please notify
us immediately at netadmin@patni.com and delete this mail. 
_____________________________________________________________________

[-- Attachment #2: kernel_softirq_printk.patch --]
[-- Type: application/octet-stream, Size: 837 bytes --]

--- linux-2.6.14-rc3.orig/kernel/softirq.c	2005-10-06 15:30:37.000000000 +0530
+++ linux-2.6.14-rc3/kernel/softirq.c	2005-10-06 18:59:24.000000000 +0530
@@ -328,7 +328,7 @@ EXPORT_SYMBOL(tasklet_init);
 void tasklet_kill(struct tasklet_struct *t)
 {
 	if (in_interrupt())
-		printk("Attempt to kill tasklet from interrupt\n");
+		printk(KERN_ERR "Attempt to kill tasklet from interrupt\n");
 
 	while (test_and_set_bit(TASKLET_STATE_SCHED, &t->state)) {
 		do
@@ -458,7 +458,7 @@ static int __devinit cpu_callback(struct
 		BUG_ON(per_cpu(tasklet_hi_vec, hotcpu).list);
 		p = kthread_create(ksoftirqd, hcpu, "ksoftirqd/%d", hotcpu);
 		if (IS_ERR(p)) {
-			printk("ksoftirqd for %i failed\n", hotcpu);
+			printk(KERN_ERR "ksoftirqd for %i failed\n", hotcpu);
 			return NOTIFY_BAD;
 		}
 		kthread_bind(p, hotcpu);

[-- Attachment #3: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] printk : kernel/softirq.c

[Christophe Lucas]

[-- Attachment #1: Type: text/plain, Size: 363 bytes --]

Milind A Choudhary(Patni) (milind.choudhary@patni.com) wrote:
> Description:
> printk() calls should include appropriate KERN_* constant.
> 
> Signed-off-by: Milind A Choudhary <milind.choudhary@patni.com>

Hi,

You seems to make printk patch. Have you made all patches for arch/i386
as you have begun ?

Have a nice day,

				- Christophe (clucas@rotomalug.org)

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

RE: [KJ] [PATCH] printk : kernel/softirq.c

[Milind A Choudhary(Patni)]

[-- Attachment #1: Type: text/plain, Size: 1572 bytes --]


Christophe Lucas [clucas@rotomalug.org] Wrote::

>
>Milind A Choudhary(Patni) (milind.choudhary@patni.com) wrote:
>> Description:
>> printk() calls should include appropriate KERN_* constant.
>> 
>> Signed-off-by: Milind A Choudhary <milind.choudhary@patni.com>
>
>Hi,
>
>You seems to make printk patch. Have you made all patches for arch/i386
>as you have begun ?
>
These are my first patches thats why i thougt
doing some printk work would be a  good startup..
I've started looking into kernel/* 
haven't yet looked at arch/i386.
are you planning to take it up?

I'd like to know how do we,@ KJ, ensure that there is no repetition of work..
is the work delegated or voluntarily taken up throgh such discussions only?
kindly let me know.

~Milind



http://www.patni.com
World-Wide Partnerships. World-Class Solutions.
_____________________________________________________________________

This e-mail message may contain proprietary, confidential or legally
privileged information for the sole use of the person or entity to
whom this message was originally addressed. Any review, e-transmission
dissemination or other use of or taking of any action in reliance upon
this information by persons or entities other than the intended
recipient is prohibited. If you have received this e-mail in error
kindly delete  this e-mail from your records. If it appears that this
mail has been forwarded to you without proper authority, please notify
us immediately at netadmin@patni.com and delete this mail. 
_____________________________________________________________________

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] printk : kernel/softirq.c

[Christophe Lucas]

[-- Attachment #1: Type: text/plain, Size: 976 bytes --]

Milind A Choudhary(Patni) (milind.choudhary@patni.com) wrote:
> 
> Christophe Lucas [clucas@rotomalug.org] Wrote::
> 
> >
> >Milind A Choudhary(Patni) (milind.choudhary@patni.com) wrote:
> >> Description:
> >> printk() calls should include appropriate KERN_* constant.
> >> 
> >> Signed-off-by: Milind A Choudhary <milind.choudhary@patni.com>
> >
> >Hi,
> >
> >You seems to make printk patch. Have you made all patches for arch/i386
> >as you have begun ?
> >
> These are my first patches thats why i thougt
> doing some printk work would be a  good startup..
> I've started looking into kernel/* 
> haven't yet looked at arch/i386.
> are you planning to take it up?

No in a really next future.

> 
> I'd like to know how do we,@ KJ, ensure that there is no repetition of work..
> is the work delegated or voluntarily taken up throgh such discussions only?
> kindly let me know.

As we do now : we ask on this ml :)

Have a nice day,

				- Christophe (clucas@rotomalug.org)

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

Re: [KJ] [PATCH] printk : kernel/softirq.c

[Arthur Othieno]

[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]

On Fri, Oct 07, 2005 at 11:04:12AM +0530, Milind A Choudhary(Patni) wrote:
> Description:
> printk() calls should include appropriate KERN_* constant.
> 
> Signed-off-by: Milind A Choudhary <milind.choudhary@patni.com>
> 
> The patch
> Index: linux-2.6.14-rc3/kernel/softirq.c
> ===================================================================
> --- linux-2.6.14-rc3.orig/kernel/softirq.c	2005-10-06 15:30:37.000000000 +0530
> +++ linux-2.6.14-rc3/kernel/softirq.c	2005-10-06 18:59:24.000000000 +0530
> @@ -328,7 +328,7 @@ EXPORT_SYMBOL(tasklet_init);
>  void tasklet_kill(struct tasklet_struct *t)
>  {
>  	if (in_interrupt())
> -		printk("Attempt to kill tasklet from interrupt\n");
> +		printk(KERN_ERR "Attempt to kill tasklet from interrupt\n");

KERN_ERR is usually on the error path, which isn't the case here. As
this is just a warning, KERN_WARNING would be more appropriate here, no?

>  	while (test_and_set_bit(TASKLET_STATE_SCHED, &t->state)) {
>  		do
> @@ -458,7 +458,7 @@ static int __devinit cpu_callback(struct
>  		BUG_ON(per_cpu(tasklet_hi_vec, hotcpu).list);
>  		p = kthread_create(ksoftirqd, hcpu, "ksoftirqd/%d", hotcpu);
>  		if (IS_ERR(p)) {
> -			printk("ksoftirqd for %i failed\n", hotcpu);
> +			printk(KERN_ERR "ksoftirqd for %i failed\n", hotcpu);
>  			return NOTIFY_BAD;
>  		}
>  		kthread_bind(p, hotcpu);
> 

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors