Re: [vendor-sec] Re: [BUG/PATCH/RFC] Oops while completing async USB via usbdevio

[Greg KH <greg@kroah.com>]

On Tue, Oct 11, 2005 at 11:45:51AM +0200, Harald Welte wrote:
> On Mon, Oct 10, 2005 at 11:07:45AM -0700, Chris Wright wrote:
> > * Harald Welte (laforge@gnumonks.org) wrote:
> > > diff --git a/kernel/signal.c b/kernel/signal.c
> > > --- a/kernel/signal.c
> > > +++ b/kernel/signal.c
> > > @@ -1193,6 +1193,40 @@ kill_proc_info(int sig, struct siginfo *
> > >  	return error;
> > >  }
> > >  
> > > +/* like kill_proc_info(), but doesn't use uid/euid of "current" */
> > 
> > Maybe additional comment reminding that you most likely don't want this
> > interface.
> > 
> > Also, looks like there's same issue again:
> 
> Mh, didn't hit that bug since I don't use disconnect signals.  But it
> looks like it has the same issue.
> 
> Please consider the patch below, it
> 
> 1) changes pid_t to uid_t
> 2) exports the symbol
> 3) adresses the same task_struct referencing issue for disconnect
>    signals
> 
> I hope this now finally is the last take ;)

Ugh, but it looks like Linus already committed your previous patch, with
some changes by him.  Care to send a delta from what is currently in his
tree (2.6.14-rc4 has it) and this patch?

thanks,

greg k-h