From: Greg KH <greg@kroah.com>
To: Mark Gross <mgross@linux.intel.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org,
Sebastien.Bouchard@ca.kontron.com, mark.gross@intel.com
Subject: Re: Fwd: Telecom Clock Driver for MPCBL0010 ATCA computer blade
Date: Wed, 12 Oct 2005 15:49:19 -0700 [thread overview]
Message-ID: <20051012224919.GA1730@kroah.com> (raw)
In-Reply-To: <200510121530.00997.mgross@linux.intel.com>
On Wed, Oct 12, 2005 at 03:30:00PM -0700, Mark Gross wrote:
>
> Most significantly I moved the driver from a misc_device to a
> platform_device.
You should still use the misc_device to register your file ops, just
stick with the platform device for the sysfs stuff. You need that
misc_device in order to work properly with udev. Have you tested this
code on a udev-only system?
Other than that, it looks very good.
Oh, one minor thing:
> +#include <linux/sysfs.h>
> +#define DEBUG
> +#include <linux/device.h>
Do you always want DEBUG to be enabled? :)
thanks,
greg k-h
next prev parent reply other threads:[~2005-10-12 22:49 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-06 15:03 Fwd: Telecom Clock Driver for MPCBL0010 ATCA computer blade Mark Gross
2005-10-06 16:52 ` Jesper Juhl
2005-10-06 17:28 ` Mark Gross
2005-10-07 12:21 ` Jesper Juhl
2005-10-06 17:24 ` Fwd: " Alexey Dobriyan
2005-10-06 17:31 ` Mark Gross
2005-10-06 18:20 ` Greg KH
2005-10-06 22:54 ` Mark Gross
2005-10-06 23:15 ` Greg KH
2005-10-12 22:30 ` Mark Gross
2005-10-12 22:49 ` Greg KH [this message]
2005-10-12 23:36 ` Mark Gross
2005-10-13 1:14 ` Greg KH
2005-10-13 21:36 ` Mark Gross
2005-10-13 22:08 ` Jesper Juhl
2005-10-13 22:40 ` Greg KH
[not found] ` <9a8748490510131547s127f3167j6c9427ff3d97f878@mail.gmail.com>
[not found] ` <20051014001547.GA4647@kroah.com>
2005-10-14 1:28 ` Jesper Juhl
2005-10-06 23:45 ` Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051012224919.GA1730@kroah.com \
--to=greg@kroah.com \
--cc=Sebastien.Bouchard@ca.kontron.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.gross@intel.com \
--cc=mgross@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.