* RE: [PATCH 2/2] Convert megaraid to use pci_driver shutdown metho d
@ 2005-10-17 13:26 Kolli, Neela Syam
2005-10-17 13:42 ` Christoph Hellwig
0 siblings, 1 reply; 5+ messages in thread
From: Kolli, Neela Syam @ 2005-10-17 13:26 UTC (permalink / raw)
To: Russell King, Linux Kernel List, Andrew Morton, Greg KH
Patch looks good. Thanks for the patch.
Thanks,
Neela Syam Kolli.
-----Original Message-----
From: Russell King [mailto:rmk+lkml@arm.linux.org.uk]
Sent: Sunday, October 16, 2005 4:33 PM
To: Linux Kernel List; Andrew Morton; Greg KH; Neela.Kolli@engenio.com
Subject: Re: [PATCH 2/2] Convert megaraid to use pci_driver shutdown method
Convert megaraid to use pci_driver's shutdown method rather than
the generic device_driver shutdown method.
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
diff --git a/drivers/scsi/megaraid/megaraid_mbox.c
b/drivers/scsi/megaraid/megaraid_mbox.c
--- a/drivers/scsi/megaraid/megaraid_mbox.c
+++ b/drivers/scsi/megaraid/megaraid_mbox.c
@@ -76,7 +76,7 @@ static void megaraid_exit(void);
static int megaraid_probe_one(struct pci_dev*, const struct pci_device_id
*);
static void megaraid_detach_one(struct pci_dev *);
-static void megaraid_mbox_shutdown(struct device *);
+static void megaraid_mbox_shutdown(struct pci_dev *);
static int megaraid_io_attach(adapter_t *);
static void megaraid_io_detach(adapter_t *);
@@ -369,9 +369,7 @@ static struct pci_driver megaraid_pci_dr
.id_table = pci_id_table_g,
.probe = megaraid_probe_one,
.remove = __devexit_p(megaraid_detach_one),
- .driver = {
- .shutdown = megaraid_mbox_shutdown,
- }
+ .shutdown = megaraid_mbox_shutdown,
};
@@ -673,9 +671,9 @@ megaraid_detach_one(struct pci_dev *pdev
* Shutdown notification, perform flush cache
*/
static void
-megaraid_mbox_shutdown(struct device *device)
+megaraid_mbox_shutdown(struct pci_dev *pdev)
{
- adapter_t *adapter =
pci_get_drvdata(to_pci_dev(device));
+ adapter_t *adapter = pci_get_drvdata(pdev);
static int counter;
if (!adapter) {
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] Convert megaraid to use pci_driver shutdown metho d
2005-10-17 13:26 [PATCH 2/2] Convert megaraid to use pci_driver shutdown metho d Kolli, Neela Syam
@ 2005-10-17 13:42 ` Christoph Hellwig
2005-10-17 17:08 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2005-10-17 13:42 UTC (permalink / raw)
To: Kolli, Neela Syam
Cc: Russell King, Linux Kernel List, Andrew Morton, Greg KH,
linux-scsi
On Mon, Oct 17, 2005 at 09:26:12AM -0400, Kolli, Neela Syam wrote:
> Patch looks good. Thanks for the patch.
another 2.6.14 candidate, without it we'd easily get corruption
on shutdown when the root filesystem is on megaraid.
> From: Russell King [mailto:rmk+lkml@arm.linux.org.uk]
> Sent: Sunday, October 16, 2005 4:33 PM
> To: Linux Kernel List; Andrew Morton; Greg KH; Neela.Kolli@engenio.com
> Subject: Re: [PATCH 2/2] Convert megaraid to use pci_driver shutdown method
>
> Convert megaraid to use pci_driver's shutdown method rather than
> the generic device_driver shutdown method.
>
> Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
>
> diff --git a/drivers/scsi/megaraid/megaraid_mbox.c
> b/drivers/scsi/megaraid/megaraid_mbox.c
> --- a/drivers/scsi/megaraid/megaraid_mbox.c
> +++ b/drivers/scsi/megaraid/megaraid_mbox.c
> @@ -76,7 +76,7 @@ static void megaraid_exit(void);
>
> static int megaraid_probe_one(struct pci_dev*, const struct pci_device_id
> *);
> static void megaraid_detach_one(struct pci_dev *);
> -static void megaraid_mbox_shutdown(struct device *);
> +static void megaraid_mbox_shutdown(struct pci_dev *);
>
> static int megaraid_io_attach(adapter_t *);
> static void megaraid_io_detach(adapter_t *);
> @@ -369,9 +369,7 @@ static struct pci_driver megaraid_pci_dr
> .id_table = pci_id_table_g,
> .probe = megaraid_probe_one,
> .remove = __devexit_p(megaraid_detach_one),
> - .driver = {
> - .shutdown = megaraid_mbox_shutdown,
> - }
> + .shutdown = megaraid_mbox_shutdown,
> };
>
>
> @@ -673,9 +671,9 @@ megaraid_detach_one(struct pci_dev *pdev
> * Shutdown notification, perform flush cache
> */
> static void
> -megaraid_mbox_shutdown(struct device *device)
> +megaraid_mbox_shutdown(struct pci_dev *pdev)
> {
> - adapter_t *adapter =
> pci_get_drvdata(to_pci_dev(device));
> + adapter_t *adapter = pci_get_drvdata(pdev);
> static int counter;
>
> if (!adapter) {
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] Convert megaraid to use pci_driver shutdown metho d
2005-10-17 13:42 ` Christoph Hellwig
@ 2005-10-17 17:08 ` Greg KH
2005-10-17 17:10 ` Christoph Hellwig
0 siblings, 1 reply; 5+ messages in thread
From: Greg KH @ 2005-10-17 17:08 UTC (permalink / raw)
To: Christoph Hellwig, Kolli, Neela Syam, Russell King,
Linux Kernel List, Andrew Morton, linux-scsi
On Mon, Oct 17, 2005 at 02:42:28PM +0100, Christoph Hellwig wrote:
> On Mon, Oct 17, 2005 at 09:26:12AM -0400, Kolli, Neela Syam wrote:
> > Patch looks good. Thanks for the patch.
>
> another 2.6.14 candidate, without it we'd easily get corruption
> on shutdown when the root filesystem is on megaraid.
No, the megaraid shutdown method will be called, only if that member
isn't set will the pci shutdown call be made. So this should be safe
today, right?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] Convert megaraid to use pci_driver shutdown metho d
2005-10-17 17:08 ` Greg KH
@ 2005-10-17 17:10 ` Christoph Hellwig
2005-10-17 17:17 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2005-10-17 17:10 UTC (permalink / raw)
To: Greg KH
Cc: Christoph Hellwig, Kolli, Neela Syam, Russell King,
Linux Kernel List, Andrew Morton, linux-scsi
On Mon, Oct 17, 2005 at 10:08:55AM -0700, Greg KH wrote:
> On Mon, Oct 17, 2005 at 02:42:28PM +0100, Christoph Hellwig wrote:
> > On Mon, Oct 17, 2005 at 09:26:12AM -0400, Kolli, Neela Syam wrote:
> > > Patch looks good. Thanks for the patch.
> >
> > another 2.6.14 candidate, without it we'd easily get corruption
> > on shutdown when the root filesystem is on megaraid.
>
> No, the megaraid shutdown method will be called, only if that member
> isn't set will the pci shutdown call be made. So this should be safe
> today, right?
If that actually got fixed it's fine indeed.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] Convert megaraid to use pci_driver shutdown metho d
2005-10-17 17:10 ` Christoph Hellwig
@ 2005-10-17 17:17 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2005-10-17 17:17 UTC (permalink / raw)
To: Christoph Hellwig, Kolli, Neela Syam, Russell King,
Linux Kernel List, Andrew Morton, linux-scsi
On Mon, Oct 17, 2005 at 06:10:25PM +0100, Christoph Hellwig wrote:
> On Mon, Oct 17, 2005 at 10:08:55AM -0700, Greg KH wrote:
> > On Mon, Oct 17, 2005 at 02:42:28PM +0100, Christoph Hellwig wrote:
> > > On Mon, Oct 17, 2005 at 09:26:12AM -0400, Kolli, Neela Syam wrote:
> > > > Patch looks good. Thanks for the patch.
> > >
> > > another 2.6.14 candidate, without it we'd easily get corruption
> > > on shutdown when the root filesystem is on megaraid.
> >
> > No, the megaraid shutdown method will be called, only if that member
> > isn't set will the pci shutdown call be made. So this should be safe
> > today, right?
>
> If that actually got fixed it's fine indeed.
The code today is:
/* FIXME, once all of the existing PCI drivers have been fixed to set
* the pci shutdown function, this test can go away. */
if (!drv->driver.shutdown)
drv->driver.shutdown = pci_device_shutdown;
so we should be fine.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2005-10-17 17:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-17 13:26 [PATCH 2/2] Convert megaraid to use pci_driver shutdown metho d Kolli, Neela Syam
2005-10-17 13:42 ` Christoph Hellwig
2005-10-17 17:08 ` Greg KH
2005-10-17 17:10 ` Christoph Hellwig
2005-10-17 17:17 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.