All of lore.kernel.org
 help / color / mirror / Atom feed
* 2.6.14-rc4-rt6, skge vs. sk98lin
@ 2005-10-18  1:45 Fernando Lopez-Lezcano
  2005-10-18  1:57 ` Jeff Garzik
  0 siblings, 1 reply; 6+ messages in thread
From: Fernando Lopez-Lezcano @ 2005-10-18  1:45 UTC (permalink / raw)
  To: linux-kernel; +Cc: Ingo Molnar, nando

I'm running 2.6.14-rc4-rt6 and trying the skge driver instead of the
sk98lin and I'm getting these warnings in my logs (this is probably not
related to the rt patch):

  network driver disabled interrupts: skge_xmit_frame+0x0/0x320 [skge]

No other relevant messages around that I can see. Is this a bug? Any
information I could supply to help debug it?

-- Fernando



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: 2.6.14-rc4-rt6, skge vs. sk98lin
  2005-10-18  1:45 2.6.14-rc4-rt6, skge vs. sk98lin Fernando Lopez-Lezcano
@ 2005-10-18  1:57 ` Jeff Garzik
  2005-10-18  2:02   ` Fernando Lopez-Lezcano
  0 siblings, 1 reply; 6+ messages in thread
From: Jeff Garzik @ 2005-10-18  1:57 UTC (permalink / raw)
  To: Fernando Lopez-Lezcano; +Cc: linux-kernel, Ingo Molnar

Fernando Lopez-Lezcano wrote:
> I'm running 2.6.14-rc4-rt6 and trying the skge driver instead of the
> sk98lin and I'm getting these warnings in my logs (this is probably not
> related to the rt patch):
> 
>   network driver disabled interrupts: skge_xmit_frame+0x0/0x320 [skge]
> 
> No other relevant messages around that I can see. Is this a bug? Any
> information I could supply to help debug it?

This is a bogus message added by the -rt patch.  It is not a bug.

The trylock scheme in some newer net drivers (grep for NETDEV_TX_LOCKED) 
uses local_irq_save/restore because there is no 
spin_trylock_irqsave/spin_trylock_failed_irqrestore API.

	Jeff



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: 2.6.14-rc4-rt6, skge vs. sk98lin
  2005-10-18  1:57 ` Jeff Garzik
@ 2005-10-18  2:02   ` Fernando Lopez-Lezcano
  2005-10-18 16:50     ` Stephen Hemminger
  0 siblings, 1 reply; 6+ messages in thread
From: Fernando Lopez-Lezcano @ 2005-10-18  2:02 UTC (permalink / raw)
  To: Jeff Garzik; +Cc: nando, linux-kernel, Ingo Molnar

On Mon, 2005-10-17 at 21:57 -0400, Jeff Garzik wrote:
> Fernando Lopez-Lezcano wrote:
> > I'm running 2.6.14-rc4-rt6 and trying the skge driver instead of the
> > sk98lin and I'm getting these warnings in my logs (this is probably not
> > related to the rt patch):
> > 
> >   network driver disabled interrupts: skge_xmit_frame+0x0/0x320 [skge]
> > 
> > No other relevant messages around that I can see. Is this a bug? Any
> > information I could supply to help debug it?
> 
> This is a bogus message added by the -rt patch.  It is not a bug.
> 
> The trylock scheme in some newer net drivers (grep for NETDEV_TX_LOCKED) 
> uses local_irq_save/restore because there is no 
> spin_trylock_irqsave/spin_trylock_failed_irqrestore API.

Would it have any undesirable effect to find this and comment it out?
There are quite a few messages in the logs. Knowing it is not a bug I
may try the driver a bit more (I rebooted into sk98lin just in case ;-)

Thanks for the info. 
-- Fernando



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: 2.6.14-rc4-rt6, skge vs. sk98lin
  2005-10-18  2:02   ` Fernando Lopez-Lezcano
@ 2005-10-18 16:50     ` Stephen Hemminger
  2005-10-19  6:48       ` Steven Rostedt
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Hemminger @ 2005-10-18 16:50 UTC (permalink / raw)
  To: linux-kernel

On Mon, 17 Oct 2005 19:02:33 -0700
Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU> wrote:

> On Mon, 2005-10-17 at 21:57 -0400, Jeff Garzik wrote:
> > Fernando Lopez-Lezcano wrote:
> > > I'm running 2.6.14-rc4-rt6 and trying the skge driver instead of the
> > > sk98lin and I'm getting these warnings in my logs (this is probably not
> > > related to the rt patch):
> > > 
> > >   network driver disabled interrupts: skge_xmit_frame+0x0/0x320 [skge]
> > > 
> > > No other relevant messages around that I can see. Is this a bug? Any
> > > information I could supply to help debug it?
> > 
> > This is a bogus message added by the -rt patch.  It is not a bug.
> > 
> > The trylock scheme in some newer net drivers (grep for NETDEV_TX_LOCKED) 
> > uses local_irq_save/restore because there is no 
> > spin_trylock_irqsave/spin_trylock_failed_irqrestore API.
> 
> Would it have any undesirable effect to find this and comment it out?
> There are quite a few messages in the logs. Knowing it is not a bug I
> may try the driver a bit more (I rebooted into sk98lin just in case ;-)
> 
> Thanks for the info. 
> -- Fernando

Or get the -rt folks to come with a better way.

> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


-- 
Stephen Hemminger <shemminger@osdl.org>
OSDL http://developer.osdl.org/~shemminger

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: 2.6.14-rc4-rt6, skge vs. sk98lin
  2005-10-18 16:50     ` Stephen Hemminger
@ 2005-10-19  6:48       ` Steven Rostedt
  2005-10-19 11:15         ` Ingo Molnar
  0 siblings, 1 reply; 6+ messages in thread
From: Steven Rostedt @ 2005-10-19  6:48 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: linux-kernel, Ingo Molnar


On Tue, 18 Oct 2005, Stephen Hemminger wrote:

> On Mon, 17 Oct 2005 19:02:33 -0700
> Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU> wrote:
>
> > On Mon, 2005-10-17 at 21:57 -0400, Jeff Garzik wrote:
> > > Fernando Lopez-Lezcano wrote:
> > > > I'm running 2.6.14-rc4-rt6 and trying the skge driver instead of the
> > > > sk98lin and I'm getting these warnings in my logs (this is probably not
> > > > related to the rt patch):
> > > >
> > > >   network driver disabled interrupts: skge_xmit_frame+0x0/0x320 [skge]
> > > >
> > > > No other relevant messages around that I can see. Is this a bug? Any
> > > > information I could supply to help debug it?
> > >
> > > This is a bogus message added by the -rt patch.  It is not a bug.
> > >
> > > The trylock scheme in some newer net drivers (grep for NETDEV_TX_LOCKED)
> > > uses local_irq_save/restore because there is no
> > > spin_trylock_irqsave/spin_trylock_failed_irqrestore API.
> >
> > Would it have any undesirable effect to find this and comment it out?
> > There are quite a few messages in the logs. Knowing it is not a bug I
> > may try the driver a bit more (I rebooted into sk98lin just in case ;-)
> >
> > Thanks for the info.
> > -- Fernando
>
> Or get the -rt folks to come with a better way.
>

Like adding a spin_trylock_irqsave/spin_trylock_failed_irqrestore API?

-- Steve

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: 2.6.14-rc4-rt6, skge vs. sk98lin
  2005-10-19  6:48       ` Steven Rostedt
@ 2005-10-19 11:15         ` Ingo Molnar
  0 siblings, 0 replies; 6+ messages in thread
From: Ingo Molnar @ 2005-10-19 11:15 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: Stephen Hemminger, linux-kernel


* Steven Rostedt <rostedt@goodmis.org> wrote:

> Like adding a spin_trylock_irqsave/spin_trylock_failed_irqrestore API?

there's spin_trylock_irqsave() already, which can be used just fine.

but in any case, this is something for the -rt tree only, with which we 
dont want to pester upstream ...

	Ingo

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2005-10-19 11:15 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-18  1:45 2.6.14-rc4-rt6, skge vs. sk98lin Fernando Lopez-Lezcano
2005-10-18  1:57 ` Jeff Garzik
2005-10-18  2:02   ` Fernando Lopez-Lezcano
2005-10-18 16:50     ` Stephen Hemminger
2005-10-19  6:48       ` Steven Rostedt
2005-10-19 11:15         ` Ingo Molnar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.