* [uml-devel] [PATCH] build fix for uml/amd64
@ 2005-10-18 21:45 ` Al Viro
0 siblings, 0 replies; 5+ messages in thread
From: Al Viro @ 2005-10-18 21:45 UTC (permalink / raw)
To: Linus Torvalds; +Cc: jdike, linux-kernel, user-mode-linux-devel
Missing half of the [PATCH] uml: Fix sysrq-r support for skas mode
We need to remove these (UPT_[DEFG]S) from the read side as well as the
write one - otherwise it simply won't build.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
----
IMO it should go in before 2.6.14. Jeff, could you ACK that?
diff -urN RC14-rc4-git4-hppfs-sparse/arch/um/include/sysdep-x86_64/ptrace.h RC14-rc4-git4-pending-1/arch/um/include/sysdep-x86_64/ptrace.h
--- RC14-rc4-git4-hppfs-sparse/arch/um/include/sysdep-x86_64/ptrace.h 2005-10-10 21:36:17.000000000 -0400
+++ RC14-rc4-git4-pending-1/arch/um/include/sysdep-x86_64/ptrace.h 2005-10-16 03:10:04.000000000 -0400
@@ -183,10 +183,6 @@
case RBP: val = UPT_RBP(regs); break; \
case ORIG_RAX: val = UPT_ORIG_RAX(regs); break; \
case CS: val = UPT_CS(regs); break; \
- case DS: val = UPT_DS(regs); break; \
- case ES: val = UPT_ES(regs); break; \
- case FS: val = UPT_FS(regs); break; \
- case GS: val = UPT_GS(regs); break; \
case EFLAGS: val = UPT_EFLAGS(regs); break; \
default : \
panic("Bad register in UPT_REG : %d\n", reg); \
-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] build fix for uml/amd64
@ 2005-10-18 21:45 ` Al Viro
0 siblings, 0 replies; 5+ messages in thread
From: Al Viro @ 2005-10-18 21:45 UTC (permalink / raw)
To: Linus Torvalds; +Cc: jdike, linux-kernel, user-mode-linux-devel
Missing half of the [PATCH] uml: Fix sysrq-r support for skas mode
We need to remove these (UPT_[DEFG]S) from the read side as well as the
write one - otherwise it simply won't build.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
----
IMO it should go in before 2.6.14. Jeff, could you ACK that?
diff -urN RC14-rc4-git4-hppfs-sparse/arch/um/include/sysdep-x86_64/ptrace.h RC14-rc4-git4-pending-1/arch/um/include/sysdep-x86_64/ptrace.h
--- RC14-rc4-git4-hppfs-sparse/arch/um/include/sysdep-x86_64/ptrace.h 2005-10-10 21:36:17.000000000 -0400
+++ RC14-rc4-git4-pending-1/arch/um/include/sysdep-x86_64/ptrace.h 2005-10-16 03:10:04.000000000 -0400
@@ -183,10 +183,6 @@
case RBP: val = UPT_RBP(regs); break; \
case ORIG_RAX: val = UPT_ORIG_RAX(regs); break; \
case CS: val = UPT_CS(regs); break; \
- case DS: val = UPT_DS(regs); break; \
- case ES: val = UPT_ES(regs); break; \
- case FS: val = UPT_FS(regs); break; \
- case GS: val = UPT_GS(regs); break; \
case EFLAGS: val = UPT_EFLAGS(regs); break; \
default : \
panic("Bad register in UPT_REG : %d\n", reg); \
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [uml-devel] [PATCH] build fix for uml/amd64
2005-10-18 21:45 ` Al Viro
@ 2005-10-19 0:26 ` Blaisorblade
-1 siblings, 0 replies; 5+ messages in thread
From: Blaisorblade @ 2005-10-19 0:26 UTC (permalink / raw)
To: user-mode-linux-devel; +Cc: Al Viro, Linus Torvalds, jdike, linux-kernel
On Tuesday 18 October 2005 23:45, Al Viro wrote:
> Missing half of the [PATCH] uml: Fix sysrq-r support for skas mode
> We need to remove these (UPT_[DEFG]S) from the read side as well as the
> write one - otherwise it simply won't build.
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ----
>
> IMO it should go in before 2.6.14. Jeff, could you ACK that?
Acked-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
and probably
Acked-by: Jeff Dike <jdike@addtoit.com>
(we already discussed this via IRC, but since I couldn't test the patch at the
moment, I asked Jeff to send it in my place, and then I've been busy).
> diff -urN RC14-rc4-git4-hppfs-sparse/arch/um/include/sysdep-x86_64/ptrace.h
> RC14-rc4-git4-pending-1/arch/um/include/sysdep-x86_64/ptrace.h ---
> RC14-rc4-git4-hppfs-sparse/arch/um/include/sysdep-x86_64/ptrace.h 2005-10-1
>0 21:36:17.000000000 -0400 +++
> RC14-rc4-git4-pending-1/arch/um/include/sysdep-x86_64/ptrace.h 2005-10-16
> 03:10:04.000000000 -0400 @@ -183,10 +183,6 @@
> case RBP: val = UPT_RBP(regs); break; \
> case ORIG_RAX: val = UPT_ORIG_RAX(regs); break; \
> case CS: val = UPT_CS(regs); break; \
> - case DS: val = UPT_DS(regs); break; \
> - case ES: val = UPT_ES(regs); break; \
> - case FS: val = UPT_FS(regs); break; \
> - case GS: val = UPT_GS(regs); break; \
> case EFLAGS: val = UPT_EFLAGS(regs); break; \
> default : \
> panic("Bad register in UPT_REG : %d\n", reg); \
--
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade
___________________________________
Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB
http://mail.yahoo.it
-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [uml-devel] [PATCH] build fix for uml/amd64
@ 2005-10-19 0:26 ` Blaisorblade
0 siblings, 0 replies; 5+ messages in thread
From: Blaisorblade @ 2005-10-19 0:26 UTC (permalink / raw)
To: user-mode-linux-devel; +Cc: Al Viro, Linus Torvalds, jdike, linux-kernel
On Tuesday 18 October 2005 23:45, Al Viro wrote:
> Missing half of the [PATCH] uml: Fix sysrq-r support for skas mode
> We need to remove these (UPT_[DEFG]S) from the read side as well as the
> write one - otherwise it simply won't build.
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ----
>
> IMO it should go in before 2.6.14. Jeff, could you ACK that?
Acked-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
and probably
Acked-by: Jeff Dike <jdike@addtoit.com>
(we already discussed this via IRC, but since I couldn't test the patch at the
moment, I asked Jeff to send it in my place, and then I've been busy).
> diff -urN RC14-rc4-git4-hppfs-sparse/arch/um/include/sysdep-x86_64/ptrace.h
> RC14-rc4-git4-pending-1/arch/um/include/sysdep-x86_64/ptrace.h ---
> RC14-rc4-git4-hppfs-sparse/arch/um/include/sysdep-x86_64/ptrace.h 2005-10-1
>0 21:36:17.000000000 -0400 +++
> RC14-rc4-git4-pending-1/arch/um/include/sysdep-x86_64/ptrace.h 2005-10-16
> 03:10:04.000000000 -0400 @@ -183,10 +183,6 @@
> case RBP: val = UPT_RBP(regs); break; \
> case ORIG_RAX: val = UPT_ORIG_RAX(regs); break; \
> case CS: val = UPT_CS(regs); break; \
> - case DS: val = UPT_DS(regs); break; \
> - case ES: val = UPT_ES(regs); break; \
> - case FS: val = UPT_FS(regs); break; \
> - case GS: val = UPT_GS(regs); break; \
> case EFLAGS: val = UPT_EFLAGS(regs); break; \
> default : \
> panic("Bad register in UPT_REG : %d\n", reg); \
--
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade
___________________________________
Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB
http://mail.yahoo.it
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [uml-devel] [PATCH] build fix for uml/amd64
2005-10-18 21:45 ` Al Viro
(?)
(?)
@ 2005-10-19 1:22 ` Jeff Dike
-1 siblings, 0 replies; 5+ messages in thread
From: Jeff Dike @ 2005-10-19 1:22 UTC (permalink / raw)
To: Linus Torvalds, Al Viro; +Cc: user-mode-linux-devel
On Tue, Oct 18, 2005 at 10:45:17PM +0100, Al Viro wrote:
> Missing half of the [PATCH] uml: Fix sysrq-r support for skas mode
> We need to remove these (UPT_[DEFG]S) from the read side as well as the
> write one - otherwise it simply won't build.
>
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ----
>
> IMO it should go in before 2.6.14. Jeff, could you ACK that?
Yup.
Acked-by: Jeff Dike <jdike@addtoit.com>
-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2005-10-19 1:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-18 21:45 [uml-devel] [PATCH] build fix for uml/amd64 Al Viro
2005-10-18 21:45 ` Al Viro
2005-10-19 0:26 ` [uml-devel] " Blaisorblade
2005-10-19 0:26 ` Blaisorblade
2005-10-19 1:22 ` Jeff Dike
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.