-rt10 build problem [WAS]Re: scsi_eh / 1394 bug - -rt7

-rt10 build problem [WAS]Re: scsi_eh / 1394 bug - -rt7

[Mark Knecht]

On 10/19/05, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > > Attached scsi removable disk sda at scsi0, channel 0, id 0, lun 0
> > > usb 2-1: USB disconnect, address 2
> > > prev->state: 2 != TASK_RUNNING??
> > > scsi_eh_0/12648[CPU#0]: BUG in __schedule at kernel/sched.c:3326
> > >  [<c01048b9>] dump_stack+0x19/0x20 (20)
> > >  [<c011e766>] __WARN_ON+0x46/0x80 (12)
> > >  [<c02c0bf7>] __schedule+0x547/0x790 (84)
> > >  [<c012057a>] do_exit+0x26a/0x430 (28)
> > >  [<c010147b>] kernel_thread_helper+0xb/0x10 (1020129312)
> > >
> >
> > This is also a problem in the upstream kernel.  It's just that RT
> > catches it!  Here's the patch. I'll also write one for the upstream
> > kernel, although this patch would probably work there as well. But
> > I'll make it official.
> >
> > Ingo,
> >
> > Here's the patch.  The problem is similar to the pcmcia bug.  It seems
> > that the loop usually exits in the TASK_INTERRUPTIBLE state.
>
> thanks, applied and released in 2.6.14-rc4-rt10.
>
>         Ingo
>

Problem building 2.6.14-rc4-rt10. The only change to my config file
was to turn on a few options for Mac disks. I doubt that's involved
with this. I will send the .config file if requested.

Thanks for looking after this SCSI error. I'm anxious to see that go away.

Cheers,
Mark

  CC      kernel/pid.o
  CC      kernel/rcupdate.o
  CC      kernel/intermodule.o
kernel/intermodule.c:178: warning: `inter_module_register' is
deprecated (declared at kernel/intermodule.c:38)
kernel/intermodule.c:179: warning: `inter_module_unregister' is
deprecated (declared at kernel/intermodule.c:78)
kernel/intermodule.c:181: warning: `inter_module_put' is deprecated
(declared at kernel/intermodule.c:159)
  CC      kernel/extable.o
  CC      kernel/params.o
  CC      kernel/posix-timers.o
  CC      kernel/kthread.o
  CC      kernel/wait.o
  CC      kernel/kfifo.o
  CC      kernel/sys_ni.o
  CC      kernel/posix-cpu-timers.o
  CC      kernel/ktimers.o
kernel/ktimers.c: In function `check_ktimer_signal':
kernel/ktimers.c:1212: error: request for member `tv' in something not
a structure or union
kernel/ktimers.c:1212: error: request for member `tv' in something not
a structure or union
kernel/ktimers.c:1214: error: request for member `tv' in something not
a structure or union
kernel/ktimers.c:1214: error: request for member `tv' in something not
a structure or union
kernel/ktimers.c:1218: error: request for member `tv' in something not
a structure or union
kernel/ktimers.c:1218: error: request for member `tv' in something not
a structure or union
kernel/ktimers.c:1220: error: request for member `tv' in something not
a structure or union
kernel/ktimers.c:1220: error: request for member `tv' in something not
a structure or union
kernel/ktimers.c:1222: error: request for member `tv' in something not
a structure or union
kernel/ktimers.c:1222: error: request for member `tv' in something not
a structure or union
make[1]: *** [kernel/ktimers.o] Error 1
make: *** [kernel] Error 2
lightning linux #

Re: -rt10 build problem [WAS]Re: scsi_eh / 1394 bug - -rt7

[Russell King]

On Wed, Oct 19, 2005 at 07:50:11AM -0700, Mark Knecht wrote:
> On 10/19/05, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > * Steven Rostedt <rostedt@goodmis.org> wrote:
...

I'm sorry, but I seem to have been added to the CC list for this thread
a while back, and I don't remember why.  I haven't seen anything relevant
to me recently, so please drop me from the CC list.  Thanks.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

Re: -rt10 build problem [WAS]Re: scsi_eh / 1394 bug - -rt7

[Ingo Molnar]

* Mark Knecht <markknecht@gmail.com> wrote:

> Problem building 2.6.14-rc4-rt10. The only change to my config file 
> was to turn on a few options for Mac disks. I doubt that's involved 
> with this. I will send the .config file if requested.

does the patch below fix it?

	Ingo

Index: linux/kernel/ktimers.c
===================================================================
--- linux.orig/kernel/ktimers.c
+++ linux/kernel/ktimers.c
@@ -1097,17 +1097,19 @@ static void check_ktimer_signal(struct k
 
 		printk("\n");
 		printk("expires:   %u/%u\n",
-			timer->expires.tv.sec, timer->expires.tv.nsec);
+			ktime_get_high(timer->expires),
+			ktime_get_low(timer->expires));
 		printk("expired:   %u/%u\n",
-			timer->expired.tv.sec, timer->expired.tv.nsec);
-		printk("      at:  %d\n",
-			timer->expiry_mode);
+			ktime_get_high(timer->expired),
+			ktime_get_low(timer->expired));
+		printk("      at:  %d\n", timer->expiry_mode);
 		printk("interval:  %u/%u\n",
-			timer->interval.tv.sec, timer->interval.tv.nsec);
+			ktime_get_high(timer->interval),
+			ktime_get_low(timer->interval));
 		printk("now:       %u/%u\n",
-			now.tv.sec, now.tv.nsec);
+			ktime_get_high(now), ktime_get_low(now));
 		printk("rem:       %u/%u\n",
-			rem.tv.sec, rem.tv.nsec);
+			ktime_get_high(rem), ktime_get_low(rem));
 		printk("overrun:   %d\n", timer->overrun);
 #ifdef CONFIG_HIGH_RES_TIMERS
 		printk("getoffset: %p\n", base->getoffset);

Re: -rt10 build problem [WAS]Re: scsi_eh / 1394 bug - -rt7

[Mark Knecht]

On 10/19/05, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Mark Knecht <markknecht@gmail.com> wrote:
>
> > Problem building 2.6.14-rc4-rt10. The only change to my config file
> > was to turn on a few options for Mac disks. I doubt that's involved
> > with this. I will send the .config file if requested.
>
> does the patch below fix it?
>
>         Ingo
>

Sorry. Please resend the patch as a file. My trying to copy it from
GMail has apparently killed it:

lightning linux # patch -p1 --dry-run <~mark/patch-ktimer
patching file kernel/ktimers.c
Hunk #1 FAILED at 1097.
1 out of 1 hunk FAILED -- saving rejects to file kernel/ktimers.c.rej
lightning linux #

Re: -rt10 build problem [WAS]Re: scsi_eh / 1394 bug - -rt7

[Ingo Molnar]

* Mark Knecht <markknecht@gmail.com> wrote:

> Sorry. Please resend the patch as a file. My trying to copy it from 
> GMail has apparently killed it:

just pick up -rt11.

	Ingo

Re: -rt10 build problem [WAS]Re: scsi_eh / 1394 bug - -rt7

[Mark Knecht]

On 10/19/05, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Mark Knecht <markknecht@gmail.com> wrote:
>
> > Sorry. Please resend the patch as a file. My trying to copy it from
> > GMail has apparently killed it:
>
> just pick up -rt11.
>
>         Ingo
>

Thanks Ingo. Sorry for being such a putz! ;-)

2.6.14-rc4-rt11 is up and running. No SCSI errors. No xruns as of yet.

Thanks very much,
Mark

Re: -rt10 build problem [WAS]Re: scsi_eh / 1394 bug - -rt7

[Ingo Molnar]

* Mark Knecht <markknecht@gmail.com> wrote:

> On 10/19/05, Ingo Molnar <mingo@elte.hu> wrote:
> >
> > * Mark Knecht <markknecht@gmail.com> wrote:
> >
> > > Sorry. Please resend the patch as a file. My trying to copy it from
> > > GMail has apparently killed it:
> >
> > just pick up -rt11.
> >
> >         Ingo
> >
> 
> Thanks Ingo. Sorry for being such a putz! ;-)

nah, browsers can be a PITA when it comes to saving plaintext patches.

> 2.6.14-rc4-rt11 is up and running. No SCSI errors. No xruns as of yet.

great!

	Ingo