Re: [EXPERIMENT,RFC] FAT: Add "flush" option for hotplug devices

[Christoph Hellwig <hch@infradead.org>]

On Sat, Oct 22, 2005 at 07:45:31PM +0900, OGAWA Hirofumi wrote:
> Christoph Hellwig <hch@infradead.org> writes:
> 
> >> +++ linux-2.6.14-rc4-hirofumi/fs/fat/flush.c	2005-10-21 00:25:22.000000000 +0900
> >> @@ -0,0 +1,90 @@
> >> +/*
> >> + * Copyright (C) 2005, OGAWA Hirofumi
> >> + * Released under GPL v2.
> >> 
> > Except for placing the flush time in the msdosfs SB there is nothing
> > filesystem-specific in this file.  Please place it in generic code,
> > that way there's no reason to export all these deeply internal
> > symbols either.
> 
> OK, except filemap_write_and_wait().
> 
> Many filesystems does
> 
> 	filemap_fdatawrite(mapping);
> 	filemap_fdatawait(mapping);
> 
> Don't you want filemap_write_and_wait()?

Yes, that doesn't fall under the odd exports above.  Care to submit a patch to
export it (non-_GPL) and convert all users of the above pattern to it?