From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [EXPERIMENT,RFC] FAT: Add "flush" option for hotplug devices
Date: Sat, 22 Oct 2005 19:45:31 +0900 [thread overview]
Message-ID: <87hdb9de44.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <20051022101552.GA2403@infradead.org> (Christoph Hellwig's message of "Sat, 22 Oct 2005 11:15:52 +0100")
Christoph Hellwig <hch@infradead.org> writes:
>> +++ linux-2.6.14-rc4-hirofumi/fs/fat/flush.c 2005-10-21 00:25:22.000000000 +0900
>> @@ -0,0 +1,90 @@
>> +/*
>> + * Copyright (C) 2005, OGAWA Hirofumi
>> + * Released under GPL v2.
>>
> Except for placing the flush time in the msdosfs SB there is nothing
> filesystem-specific in this file. Please place it in generic code,
> that way there's no reason to export all these deeply internal
> symbols either.
OK, except filemap_write_and_wait().
Many filesystems does
filemap_fdatawrite(mapping);
filemap_fdatawait(mapping);
Don't you want filemap_write_and_wait()?
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2005-10-22 10:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-20 16:41 [EXPERIMENT,RFC] FAT: Add "flush" option for hotplug devices OGAWA Hirofumi
2005-10-20 20:50 ` Andrew Morton
2005-10-20 21:08 ` running linux TCP/IP stack on a real slow machine Kallol Biswas
2005-10-22 7:45 ` [EXPERIMENT,RFC] FAT: Add "flush" option for hotplug devices OGAWA Hirofumi
2005-10-22 10:15 ` Christoph Hellwig
2005-10-22 10:45 ` OGAWA Hirofumi [this message]
2005-10-22 10:56 ` Christoph Hellwig
2005-10-22 11:24 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hdb9de44.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.