* [PATCH] fix alpha breakage
@ 2005-10-26 10:06 Al Viro
2005-10-26 12:21 ` Ivan Kokshaysky
0 siblings, 1 reply; 3+ messages in thread
From: Al Viro @ 2005-10-26 10:06 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Andrew Morton, linux-kernel
barrier.h uses barrier() in non-SMP case. And doesn't include
compiler.h.
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
----
diff -urN RC14-rc5-git5-base/include/asm-alpha/barrier.h current/include/asm-alpha/barrier.h
--- RC14-rc5-git5-base/include/asm-alpha/barrier.h 2005-10-26 01:00:39.000000000 -0400
+++ current/include/asm-alpha/barrier.h 2005-10-26 03:38:24.000000000 -0400
@@ -1,6 +1,8 @@
#ifndef __BARRIER_H
#define __BARRIER_H
+#include <linux/compiler.h>
+
#define mb() \
__asm__ __volatile__("mb": : :"memory")
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix alpha breakage
2005-10-26 10:06 [PATCH] fix alpha breakage Al Viro
@ 2005-10-26 12:21 ` Ivan Kokshaysky
0 siblings, 0 replies; 3+ messages in thread
From: Ivan Kokshaysky @ 2005-10-26 12:21 UTC (permalink / raw)
To: Al Viro; +Cc: Linus Torvalds, Andrew Morton, linux-kernel
On Wed, Oct 26, 2005 at 11:06:23AM +0100, Al Viro wrote:
> barrier.h uses barrier() in non-SMP case. And doesn't include
> compiler.h.
Thanks, but better use <asm-alpha/compiler.h> because of potential
problems with the "inline" redefinition.
Ivan.
--- 2.6.14-rc5-git6/include/asm-alpha/barrier.h Wed Oct 26 14:43:16 2005
+++ linux/include/asm-alpha/barrier.h Wed Oct 26 15:03:47 2005
@@ -1,6 +1,8 @@
#ifndef __BARRIER_H
#define __BARRIER_H
+#include <asm/compiler.h>
+
#define mb() \
__asm__ __volatile__("mb": : :"memory")
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix alpha breakage
@ 2005-10-29 8:53 Norbert Tretkowski
0 siblings, 0 replies; 3+ messages in thread
From: Norbert Tretkowski @ 2005-10-29 8:53 UTC (permalink / raw)
To: linux-kernel
* Ivan Kokshaysky wrote:
> On Wed, Oct 26, 2005 at 11:06:23AM +0100, Al Viro wrote:
>> barrier.h uses barrier() in non-SMP case. And doesn't include
>> compiler.h.
>
> Thanks, but better use <asm-alpha/compiler.h> because of potential
> problems with the "inline" redefinition.
Uhm, looks like this wasn't included in the final 2.6.14 release.
Norbert
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2005-10-29 8:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-10-26 10:06 [PATCH] fix alpha breakage Al Viro
2005-10-26 12:21 ` Ivan Kokshaysky
-- strict thread matches above, loose matches on Subject: below --
2005-10-29 8:53 Norbert Tretkowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.