From: "'David Gibson'" <david@gibson.dropbear.id.au>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: Adam Litke <agl@us.ibm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
hugh@veritas.com, William Irwin <wli@holomorphy.com>
Subject: Re: RFC: Cleanup / small fixes to hugetlb fault handling
Date: Thu, 27 Oct 2005 10:14:59 +1000 [thread overview]
Message-ID: <20051027001459.GA16013@localhost.localdomain> (raw)
In-Reply-To: <200510262012.j9QKCUg23575@unix-os.sc.intel.com>
On Wed, Oct 26, 2005 at 01:12:30PM -0700, Chen, Kenneth W wrote:
> David Gibson wrote on Tuesday, October 25, 2005 7:49 PM
> > - find_lock_huge_page() didn't, in fact, lock the page if it newly
> > allocated one, rather than finding it in the page cache already. As
> > far as I can tell this is a bug, so the patch corrects it.
>
> add_to_page_cache will lock the page if it was successfully added to the
> address space radix tree. I don't see a bug that you are seeing.
Ah, so it does. Thought I might be missing something.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/people/dgibson
WARNING: multiple messages have this Message-ID (diff)
From: 'David Gibson' <david@gibson.dropbear.id.au>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: Adam Litke <agl@us.ibm.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
hugh@veritas.com, William Irwin <wli@holomorphy.com>
Subject: Re: RFC: Cleanup / small fixes to hugetlb fault handling
Date: Thu, 27 Oct 2005 10:14:59 +1000 [thread overview]
Message-ID: <20051027001459.GA16013@localhost.localdomain> (raw)
In-Reply-To: <200510262012.j9QKCUg23575@unix-os.sc.intel.com>
On Wed, Oct 26, 2005 at 01:12:30PM -0700, Chen, Kenneth W wrote:
> David Gibson wrote on Tuesday, October 25, 2005 7:49 PM
> > - find_lock_huge_page() didn't, in fact, lock the page if it newly
> > allocated one, rather than finding it in the page cache already. As
> > far as I can tell this is a bug, so the patch corrects it.
>
> add_to_page_cache will lock the page if it was successfully added to the
> address space radix tree. I don't see a bug that you are seeing.
Ah, so it does. Thought I might be missing something.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/people/dgibson
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-10-27 0:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-26 2:00 RFC: Cleanup / small fixes to hugetlb fault handling David Gibson
2005-10-26 2:00 ` David Gibson
2005-10-26 2:48 ` David Gibson
2005-10-26 2:48 ` David Gibson
2005-10-26 5:06 ` __alloc_pages: 0-order allocation failed (gfp=0x1d2/0) salve vandana
2005-10-26 5:06 ` salve vandana
2005-10-26 11:12 ` salve vandana
2005-10-26 11:12 ` salve vandana
2005-10-26 18:44 ` RFC: Cleanup / small fixes to hugetlb fault handling Chen, Kenneth W
2005-10-26 18:44 ` Chen, Kenneth W
2005-10-27 0:05 ` 'David Gibson'
2005-10-27 0:05 ` 'David Gibson'
2005-10-27 0:16 ` Chen, Kenneth W
2005-10-27 0:16 ` Chen, Kenneth W
2005-10-27 0:23 ` 'David Gibson'
2005-10-27 0:23 ` 'David Gibson'
2005-10-27 6:37 ` 'David Gibson'
2005-10-27 6:37 ` 'David Gibson'
2005-10-26 20:12 ` Chen, Kenneth W
2005-10-26 20:12 ` Chen, Kenneth W
2005-10-27 0:14 ` 'David Gibson' [this message]
2005-10-27 0:14 ` 'David Gibson'
2005-10-26 21:46 ` Adam Litke
2005-10-26 21:46 ` Adam Litke
2005-10-27 0:20 ` David Gibson
2005-10-27 0:20 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051027001459.GA16013@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=agl@us.ibm.com \
--cc=hugh@veritas.com \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.