From: "Yoshinori K. Okuji" <okuji@enbug.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [patch] 64 bit disk address support (= 8192EiB disks)
Date: Fri, 28 Oct 2005 05:01:50 +0200 [thread overview]
Message-ID: <200510280501.50549.okuji@enbug.org> (raw)
In-Reply-To: <200510221253.31223.T.E.Baldwin99@members.leeds.ac.uk>
On Saturday 22 October 2005 01:53 pm, Timothy Baldwin wrote:
> That is exactly my point. POSIX uses off_t as a byte counts into files, the
> type we are discussing the name of is used for sector counts.
OK. That makes sense.
However, I do not like grub_sector_t. For me, this is still an address or an
offset. So it should be called something like grub_disk_addr_t or
grub_sector_offset_t.
> > > Also grub_off_t is used in kern/mm.c to count bytes of memory.
> >
> > What is bad?
>
> It should use grub_size_t for memory, in order follow POSIX.
It's true. So we must fix it.
Okuji
next prev parent reply other threads:[~2005-10-28 3:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-21 13:17 [patch] 64 bit disk address support (= 8192EiB disks) Timothy Baldwin
2005-10-21 22:18 ` Marco Gerards
2005-10-21 22:24 ` Yoshinori K. Okuji
2005-10-21 22:29 ` Marco Gerards
2005-10-21 23:46 ` Timothy Baldwin
2005-10-22 0:06 ` Yoshinori K. Okuji
2005-10-22 11:53 ` Timothy Baldwin
2005-10-28 3:01 ` Yoshinori K. Okuji [this message]
2005-10-29 1:15 ` Timothy Baldwin
2005-10-23 22:15 ` Timothy Baldwin
2005-10-24 10:26 ` Marco Gerards
2005-10-24 19:14 ` RISC OS patches (was [patch] 64 bit disk address support (= 8192EiB disks)) Timothy Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200510280501.50549.okuji@enbug.org \
--to=okuji@enbug.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.