[2.6 patch] fix XFS_QUOTA for modular XFS

[2.6 patch] fix XFS_QUOTA for modular XFS

[Adrian Bunk]

This patch by Dimitri Puzin submitted through kernel Bugzilla #5514 
fixes the following issue:

Cannot build XFS filesystem support as module with quota support. It 
works only when the XFS filesystem support is compiled into the kernel. 
Menuconfig prevents from setting CONFIG_XFS_FS=m and CONFIG_XFS_QUOTA=y.

How to reproduce: configure the XFS filesystem with quota support as 
module. The resulting kernel won't have quota support compiled into 
xfs.ko.

Fix: Changing the fs/xfs/Kconfig file from tristate to bool lets you 
configure the quota support to be compiled into the XFS module. The 
Makefile-linux-2.6 checks only for CONFIG_XFS_QUOTA=y.


From: Dimitri Puzin <tristan-777@ddkom-online.de>
Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.14-rc5-mm1/fs/xfs/Kconfig.old	2005-10-28 19:51:02.000000000 +0200
+++ linux-2.6.14-rc5-mm1/fs/xfs/Kconfig	2005-10-28 19:51:12.000000000 +0200
@@ -24,7 +24,7 @@
 	default y
 
 config XFS_QUOTA
-	tristate "XFS Quota support"
+	bool "XFS Quota support"
 	depends on XFS_FS
 	help
 	  If you say Y here, you will be able to set limits for disk usage on

Re: [2.6 patch] fix XFS_QUOTA for modular XFS

[Nathan Scott]

On Fri, Oct 28, 2005 at 10:33:25PM +0200, Adrian Bunk wrote:
> This patch by Dimitri Puzin submitted through kernel Bugzilla #5514 
> fixes the following issue:
> ...
> From: Dimitri Puzin <tristan-777@ddkom-online.de>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

Thanks guys; feel free to add:
Signed-off-by: Nathan Scott <nathans@sgi.com>

(Or Acked-by: or whatever).

cheers.

-- 
Nathan

Re: [stable] [2.6 patch] fix XFS_QUOTA for modular XFS

[Chris Wright]

* Adrian Bunk (bunk@stusta.de) wrote:
> This patch by Dimitri Puzin submitted through kernel Bugzilla #5514 
> fixes the following issue:
> 
> Cannot build XFS filesystem support as module with quota support. It 
> works only when the XFS filesystem support is compiled into the kernel. 
> Menuconfig prevents from setting CONFIG_XFS_FS=m and CONFIG_XFS_QUOTA=y.

Thanks, will queue for -stable, but this hasn't made it upstream yet.

thanks,
-chris

Re: [stable] [2.6 patch] fix XFS_QUOTA for modular XFS

[Nathan Scott]

On Mon, Oct 31, 2005 at 01:03:05PM -0800, Chris Wright wrote:
> * Adrian Bunk (bunk@stusta.de) wrote:
> > This patch by Dimitri Puzin submitted through kernel Bugzilla #5514 
> > fixes the following issue:
> > 
> > Cannot build XFS filesystem support as module with quota support. It 
> > works only when the XFS filesystem support is compiled into the kernel. 
> > Menuconfig prevents from setting CONFIG_XFS_FS=m and CONFIG_XFS_QUOTA=y.
> 
> Thanks, will queue for -stable, but this hasn't made it upstream yet.

Sorry, public holiday here has meant no action on that front - it
is "good to go" though, and will be sent to Linus when I'm back in
the office.

cheers.

-- 
Nathan