All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] nfsim: trivial format string typo fix
@ 2005-11-02 14:17 KOVACS Krisztian
  2005-11-02 17:37 ` Harald Welte
  0 siblings, 1 reply; 2+ messages in thread
From: KOVACS Krisztian @ 2005-11-02 14:17 UTC (permalink / raw)
  To: netfilter-devel; +Cc: laforge, rusty

[-- Attachment #1: Type: text/plain, Size: 233 bytes --]


  Hi,

  While playing with nfsim and nf_conntrack this weekend, I've found a 
trivial typo in core/core.c. Please apply the attached patch. (Yes, 
it's trivial but obviously it causes a segfault.)

-- 
 Regards,
  Krisztian Kovacs

[-- Attachment #2: nfsim-trivial_format_string_typo_fix.patch --]
[-- Type: text/x-diff, Size: 407 bytes --]

Index: nfsim/core/core.c
===================================================================
--- nfsim/core/core.c	(revision 4423)
+++ nfsim/core/core.c	(working copy)
@@ -386,7 +386,7 @@
 	for (p = __start_module_init; p < __stop_module_init; p++) {
 		ret = (*p)();
 		if (ret)
-			nfsim_log(LOG_UI, "Initcall %p failed: %s\n", p, ret);
+			nfsim_log(LOG_UI, "Initcall %p failed: %d\n", p, ret);
 	}
 }
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] nfsim: trivial format string typo fix
  2005-11-02 14:17 [PATCH] nfsim: trivial format string typo fix KOVACS Krisztian
@ 2005-11-02 17:37 ` Harald Welte
  0 siblings, 0 replies; 2+ messages in thread
From: Harald Welte @ 2005-11-02 17:37 UTC (permalink / raw)
  To: KOVACS Krisztian; +Cc: netfilter-devel, rusty

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

On Wed, Nov 02, 2005 at 03:17:44PM +0100, KOVACS Krisztian wrote:
> 
>   Hi,
> 
>   While playing with nfsim and nf_conntrack this weekend, I've found a 
> trivial typo in core/core.c. Please apply the attached patch. (Yes, 
> it's trivial but obviously it causes a segfault.)

applied, thanks

-- 
- Harald Welte <laforge@netfilter.org>                 http://netfilter.org/
============================================================================
  "Fragmentation is like classful addressing -- an interesting early
   architectural error that shows how much experimentation was going
   on while IP was being designed."                    -- Paul Vixie

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-11-02 17:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-02 14:17 [PATCH] nfsim: trivial format string typo fix KOVACS Krisztian
2005-11-02 17:37 ` Harald Welte

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.