From: "John W. Linville" <linville@tuxdriver.com>
To: Pantelis Antoniou <panto@intracom.gr>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-embedded@ozlabs.org
Subject: Re: [patch 2.6.14] fec_8xx: make CONFIG_FEC_8XX depend on CONFIG_8xx
Date: Mon, 7 Nov 2005 13:20:34 -0500 [thread overview]
Message-ID: <20051107182031.GC13797@tuxdriver.com> (raw)
In-Reply-To: <436F07F5.1030206@intracom.gr>
On Mon, Nov 07, 2005 at 09:53:25AM +0200, Pantelis Antoniou wrote:
> John W. Linville wrote:
> >@@ -1,6 +1,6 @@
> > config FEC_8XX
> > tristate "Motorola 8xx FEC driver"
> >- depends on NET_ETHERNET
> >+ depends on NET_ETHERNET && 8xx
> > select MII
> >
> > config FEC_8XX_GENERIC_PHY
>
> Yes, this is the correct approach. Please disregard the other
> patches floating about.
Pretty sure you are right. However, a broken version already got
committed. It added FEC as a dependency. That keeps it from breaking
everyone else, but it make the driver available for Coldfire rather
than for PPC 8xx...
I'll reform that patch and repost.
John
--
John W. Linville
linville@tuxdriver.com
WARNING: multiple messages have this Message-ID (diff)
From: "John W. Linville" <linville@tuxdriver.com>
To: Pantelis Antoniou <panto@intracom.gr>
Cc: linuxppc-embedded@ozlabs.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [patch 2.6.14] fec_8xx: make CONFIG_FEC_8XX depend on CONFIG_8xx
Date: Mon, 7 Nov 2005 13:20:34 -0500 [thread overview]
Message-ID: <20051107182031.GC13797@tuxdriver.com> (raw)
In-Reply-To: <436F07F5.1030206@intracom.gr>
On Mon, Nov 07, 2005 at 09:53:25AM +0200, Pantelis Antoniou wrote:
> John W. Linville wrote:
> >@@ -1,6 +1,6 @@
> > config FEC_8XX
> > tristate "Motorola 8xx FEC driver"
> >- depends on NET_ETHERNET
> >+ depends on NET_ETHERNET && 8xx
> > select MII
> >
> > config FEC_8XX_GENERIC_PHY
>
> Yes, this is the correct approach. Please disregard the other
> patches floating about.
Pretty sure you are right. However, a broken version already got
committed. It added FEC as a dependency. That keeps it from breaking
everyone else, but it make the driver available for Coldfire rather
than for PPC 8xx...
I'll reform that patch and repost.
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2005-11-07 18:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-06 2:57 [patch 2.6.14] fec_8xx: make CONFIG_FEC_8XX depend on CONFIG_8xx John W. Linville
2005-11-07 7:53 ` Pantelis Antoniou
2005-11-07 7:53 ` Pantelis Antoniou
2005-11-07 18:20 ` John W. Linville [this message]
2005-11-07 18:20 ` John W. Linville
2005-11-07 18:24 ` [patch 2.6.14 (take #2)] " John W. Linville
2005-11-09 21:52 ` John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051107182031.GC13797@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=panto@intracom.gr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.