* [PATCH] lib - Fix broken function declaration in linux/textsearch.h
@ 2005-11-07 11:42 Ashutosh Naik
2005-11-07 20:12 ` [stable] " Greg KH
2005-11-07 21:30 ` Thomas Graf
0 siblings, 2 replies; 5+ messages in thread
From: Ashutosh Naik @ 2005-11-07 11:42 UTC (permalink / raw)
To: pablo, tgraf; +Cc: Andrew Morton, torvalds, linux-kernel, stable
This PATCH addresses the issue of the init function pointer in
lib/ts_bm.c, lib/ts_fsm.c and lib/ts_kmp.c using a mismatching
definition in linux/textsearch.h
Signed-off-by: Ashutosh Naik <ashutosh.naik@adaptec.com>
--
diff -Naurp linux-2.6.14-git10/include/linux/textsearch.h
linux-2.6.14-git10-mod/include/linux/textsearch.h
--- linux-2.6.14-git10/include/linux/textsearch.h 2005-10-28
05:32:08.000000000 +0530
+++ linux-2.6.14-git10-mod/include/linux/textsearch.h 2005-11-07
16:39:05.000000000 +0530
@@ -40,7 +40,7 @@ struct ts_state
struct ts_ops
{
const char *name;
- struct ts_config * (*init)(const void *, unsigned int,
int);
+ struct ts_config * (*init)(const void *, unsigned int,
gfp_t);
unsigned int (*find)(struct ts_config *,
struct ts_state *);
void (*destroy)(struct ts_config *);
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [stable] [PATCH] lib - Fix broken function declaration in linux/textsearch.h
2005-11-07 11:42 [PATCH] lib - Fix broken function declaration in linux/textsearch.h Ashutosh Naik
@ 2005-11-07 20:12 ` Greg KH
2005-11-07 21:28 ` Linus Torvalds
2005-11-07 21:30 ` Thomas Graf
1 sibling, 1 reply; 5+ messages in thread
From: Greg KH @ 2005-11-07 20:12 UTC (permalink / raw)
To: Ashutosh Naik; +Cc: pablo, tgraf, torvalds, linux-kernel, stable
On Mon, Nov 07, 2005 at 05:12:21PM +0530, Ashutosh Naik wrote:
> This PATCH addresses the issue of the init function pointer in
> lib/ts_bm.c, lib/ts_fsm.c and lib/ts_kmp.c using a mismatching
> definition in linux/textsearch.h
>
>
> Signed-off-by: Ashutosh Naik <ashutosh.naik@adaptec.com>
Is this upstream?
> --
> diff -Naurp linux-2.6.14-git10/include/linux/textsearch.h
> linux-2.6.14-git10-mod/include/linux/textsearch.h
> --- linux-2.6.14-git10/include/linux/textsearch.h 2005-10-28
> 05:32:08.000000000 +0530
> +++ linux-2.6.14-git10-mod/include/linux/textsearch.h 2005-11-07
> 16:39:05.000000000 +0530
> @@ -40,7 +40,7 @@ struct ts_state
> struct ts_ops
> {
> const char *name;
> - struct ts_config * (*init)(const void *, unsigned int,
> int);
> + struct ts_config * (*init)(const void *, unsigned int,
> gfp_t);
Ugh, your patch is line-wrapped, and the tabs are messed up.
Care to retry?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [stable] [PATCH] lib - Fix broken function declaration in linux/textsearch.h
2005-11-07 20:12 ` [stable] " Greg KH
@ 2005-11-07 21:28 ` Linus Torvalds
2005-11-07 21:49 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Linus Torvalds @ 2005-11-07 21:28 UTC (permalink / raw)
To: Greg KH; +Cc: Ashutosh Naik, pablo, tgraf, linux-kernel, stable
On Mon, 7 Nov 2005, Greg KH wrote:
> On Mon, Nov 07, 2005 at 05:12:21PM +0530, Ashutosh Naik wrote:
> > This PATCH addresses the issue of the init function pointer in
> > lib/ts_bm.c, lib/ts_fsm.c and lib/ts_kmp.c using a mismatching
> > definition in linux/textsearch.h
> >
> >
> > Signed-off-by: Ashutosh Naik <ashutosh.naik@adaptec.com>
>
> Is this upstream?
Yes, it's in the standard kernel. Whether it needs to be in the stable one
or not, I don't know. It certainly doesn't match the requirements (it just
removes a couple of compile warnings).
Linus
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [stable] [PATCH] lib - Fix broken function declaration in linux/textsearch.h
2005-11-07 21:28 ` Linus Torvalds
@ 2005-11-07 21:49 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2005-11-07 21:49 UTC (permalink / raw)
To: Linus Torvalds; +Cc: Ashutosh Naik, pablo, tgraf, linux-kernel, stable
On Mon, Nov 07, 2005 at 01:28:57PM -0800, Linus Torvalds wrote:
>
>
> On Mon, 7 Nov 2005, Greg KH wrote:
>
> > On Mon, Nov 07, 2005 at 05:12:21PM +0530, Ashutosh Naik wrote:
> > > This PATCH addresses the issue of the init function pointer in
> > > lib/ts_bm.c, lib/ts_fsm.c and lib/ts_kmp.c using a mismatching
> > > definition in linux/textsearch.h
> > >
> > >
> > > Signed-off-by: Ashutosh Naik <ashutosh.naik@adaptec.com>
> >
> > Is this upstream?
>
> Yes, it's in the standard kernel. Whether it needs to be in the stable one
> or not, I don't know. It certainly doesn't match the requirements (it just
> removes a couple of compile warnings).
Ok, it's dropped.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] lib - Fix broken function declaration in linux/textsearch.h
2005-11-07 11:42 [PATCH] lib - Fix broken function declaration in linux/textsearch.h Ashutosh Naik
2005-11-07 20:12 ` [stable] " Greg KH
@ 2005-11-07 21:30 ` Thomas Graf
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Graf @ 2005-11-07 21:30 UTC (permalink / raw)
To: Ashutosh Naik; +Cc: pablo, Andrew Morton, torvalds, linux-kernel, stable
* Ashutosh Naik <ashutosh_naik@adaptec.com> 2005-11-07 17:12
> This PATCH addresses the issue of the init function pointer in
> lib/ts_bm.c, lib/ts_fsm.c and lib/ts_kmp.c using a mismatching
> definition in linux/textsearch.h
This is already fixed by Al Viro's "[PATCH] gfp_t: lib/*"
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2005-11-07 21:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-07 11:42 [PATCH] lib - Fix broken function declaration in linux/textsearch.h Ashutosh Naik
2005-11-07 20:12 ` [stable] " Greg KH
2005-11-07 21:28 ` Linus Torvalds
2005-11-07 21:49 ` Greg KH
2005-11-07 21:30 ` Thomas Graf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.