* [PATCH 1/4] dlm: configfs lock
@ 2005-11-07 21:02 David Teigland
0 siblings, 0 replies; only message in thread
From: David Teigland @ 2005-11-07 21:02 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel
Need to hold the subsys semaphore while accessing the children list.
Signed-off-by: David Teigland <teigland@redhat.com>
----
diff -ur a/drivers/dlm/config.c b/drivers/dlm/config.c
--- a/drivers/dlm/config.c 2005-08-22 14:48:26.450499104 +0800
+++ b/drivers/dlm/config.c 2005-08-22 14:49:36.767809248 +0800
@@ -627,12 +627,14 @@
static struct comm *get_comm(int nodeid, struct sockaddr_storage *addr)
{
struct config_item *i;
- struct comm *cm;
+ struct comm *cm = NULL;
int found = 0;
if (!comm_list)
return NULL;
+ down(&clusters_root.subsys.su_sem);
+
list_for_each_entry(i, &comm_list->cg_children, ci_entry) {
cm = to_comm(i);
@@ -649,6 +651,7 @@
break;
}
}
+ up(&clusters_root.subsys.su_sem);
if (found)
config_item_get(i);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-11-07 21:02 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-11-07 21:02 [PATCH 1/4] dlm: configfs lock David Teigland
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.