From: William Lee Irwin III <wli@holomorphy.com>
To: Adam Litke <agl@us.ibm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
David Gibson <david@gibson.dropbear.id.au>,
hugh@veritas.com, rohit.seth@intel.com, "Chen,
Kenneth W" <kenneth.w.chen@intel.com>,
akpm@osdl.org
Subject: Re: [RFC 1/2] Hugetlb fault fixes and reorg
Date: Mon, 7 Nov 2005 15:30:53 -0800 [thread overview]
Message-ID: <20051107233053.GG29402@holomorphy.com> (raw)
In-Reply-To: <1131399496.25133.103.camel@localhost.localdomain>
On Mon, Nov 07, 2005 at 03:38:16PM -0600, Adam Litke wrote:
> (Patch originally from David Gibson <david@gibson.dropbear.id.au>)
> Initial Post: Tue. 25 Oct 2005
> -static struct page *find_lock_huge_page(struct address_space *mapping,
> - unsigned long idx)
> +static struct page *find_or_alloc_huge_page(struct address_space *mapping,
> + unsigned long idx)
> {
> struct page *page;
> int err;
> - struct inode *inode = mapping->host;
> - unsigned long size;
This patch is a combination of function renaming, variable
initialization/assignment and return path/etc. oddities, plus some
functional changes (did I catch them all?) which apparently took a bit
of effort to get to after sifting through the rest of that.
Dump the parallel cleanups or split them into pure cleanup and pure
functional patches. I don't mind the cleanups, I mind the mixing.
-- wli
WARNING: multiple messages have this Message-ID (diff)
From: William Lee Irwin III <wli@holomorphy.com>
To: Adam Litke <agl@us.ibm.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
David Gibson <david@gibson.dropbear.id.au>,
hugh@veritas.com, rohit.seth@intel.com, "Chen,
Kenneth W" <kenneth.w.chen@intel.com>,
akpm@osdl.org
Subject: Re: [RFC 1/2] Hugetlb fault fixes and reorg
Date: Mon, 7 Nov 2005 15:30:53 -0800 [thread overview]
Message-ID: <20051107233053.GG29402@holomorphy.com> (raw)
In-Reply-To: <1131399496.25133.103.camel@localhost.localdomain>
On Mon, Nov 07, 2005 at 03:38:16PM -0600, Adam Litke wrote:
> (Patch originally from David Gibson <david@gibson.dropbear.id.au>)
> Initial Post: Tue. 25 Oct 2005
> -static struct page *find_lock_huge_page(struct address_space *mapping,
> - unsigned long idx)
> +static struct page *find_or_alloc_huge_page(struct address_space *mapping,
> + unsigned long idx)
> {
> struct page *page;
> int err;
> - struct inode *inode = mapping->host;
> - unsigned long size;
This patch is a combination of function renaming, variable
initialization/assignment and return path/etc. oddities, plus some
functional changes (did I catch them all?) which apparently took a bit
of effort to get to after sifting through the rest of that.
Dump the parallel cleanups or split them into pure cleanup and pure
functional patches. I don't mind the cleanups, I mind the mixing.
-- wli
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-11-07 23:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-07 21:10 [RFC 0/2] Copy on write for hugetlbfs Adam Litke
2005-11-07 21:10 ` Adam Litke
2005-11-07 21:38 ` [RFC 1/2] Hugetlb fault fixes and reorg Adam Litke
2005-11-07 21:38 ` Adam Litke
2005-11-07 23:30 ` William Lee Irwin III [this message]
2005-11-07 23:30 ` William Lee Irwin III
2005-11-08 1:21 ` David Gibson
2005-11-08 1:21 ` David Gibson
2005-11-07 21:38 ` [RFC 2/2] Hugetlb COW Adam Litke
2005-11-07 21:38 ` Adam Litke
2005-11-07 21:47 ` Adam Litke
2005-11-07 21:47 ` Adam Litke
2005-11-08 3:44 ` David Gibson
2005-11-08 3:44 ` David Gibson
2005-11-08 4:17 ` David Gibson
2005-11-08 4:17 ` David Gibson
2005-11-07 23:35 ` William Lee Irwin III
2005-11-07 23:35 ` William Lee Irwin III
2005-11-08 2:53 ` David Gibson
2005-11-08 2:53 ` David Gibson
2005-11-08 3:46 ` David Gibson
2005-11-08 3:46 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051107233053.GG29402@holomorphy.com \
--to=wli@holomorphy.com \
--cc=agl@us.ibm.com \
--cc=akpm@osdl.org \
--cc=david@gibson.dropbear.id.au \
--cc=hugh@veritas.com \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rohit.seth@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.