fix sparse warning in horizon atm driver.

fix sparse warning in horizon atm driver.

[Dave Jones]

these vars get fed u32's, and are OR'd with u32's.
Chances are they were meant to be u32's.

I don't have hardware to test this, but I can't fathom
why a u16 would be used here.

drivers/atm/horizon.c:1564:12: warning: cast truncates bits from constant value (40000000 becomes 0)
drivers/atm/horizon.c:1565:12: warning: cast truncates bits from constant value (40000000 becomes 0)
drivers/atm/horizon.c:1569:12: warning: cast truncates bits from constant value (80000000 becomes 0)
drivers/atm/horizon.c:1570:12: warning: cast truncates bits from constant value (80000000 becomes 0)

Signed-off-by: Dave Jones <davej@redhat.com>

--- linus/drivers/atm/horizon.c~	2005-11-09 00:51:50.000000000 -0500
+++ linus/drivers/atm/horizon.c	2005-11-09 00:55:36.000000000 -0500
@@ -1511,8 +1511,8 @@ static inline short setup_idle_tx_channe
     // a.k.a. prepare the channel and remember that we have done so.
     
     tx_ch_desc * tx_desc = &memmap->tx_descs[tx_channel];
-    u16 rd_ptr;
-    u16 wr_ptr;
+    u32 rd_ptr;
+    u32 wr_ptr;
     u16 channel = vcc->channel;
     
     unsigned long flags;

Re: fix sparse warning in horizon atm driver.

[David S. Miller]

From: Dave Jones <davej@redhat.com>
Date: Wed, 9 Nov 2005 00:57:39 -0500

> these vars get fed u32's, and are OR'd with u32's.
> Chances are they were meant to be u32's.
> 
> I don't have hardware to test this, but I can't fathom
> why a u16 would be used here.
> 
> drivers/atm/horizon.c:1564:12: warning: cast truncates bits from constant value (40000000 becomes 0)

Hmmm... I would merge this directly, but I'd like Chas Williams
(the ATM maintainer) to glance it over first.  Can you forward
it to him (CC:'ing the linux-atm list, also mentioned in MAINTAINERS,
of course)?  Thanks.

Re: fix sparse warning in horizon atm driver.

[chas williams - CONTRACTOR]

In message <20051109055739.GA630@redhat.com>,Dave Jones writes:
>these vars get fed u32's, and are OR'd with u32's.
>Chances are they were meant to be u32's.
>
>I don't have hardware to test this, but I can't fathom
>why a u16 would be used here.

i guess someone got confused over BUFFER_PTR_MASK.  this patch 
looks fine to me.


[ATM]: [horizon] fix sparse warnings

Signed-off-by: Dave Jones <davej@redhat.com>
Signed-off-by: Chas Williams <cmas@cmf.nrl.navy.mil>

--- linus/drivers/atm/horizon.c~	2005-11-09 00:51:50.000000000 -0500
+++ linus/drivers/atm/horizon.c	2005-11-09 00:55:36.000000000 -0500
@@ -1511,8 +1511,8 @@ static inline short setup_idle_tx_channe
     // a.k.a. prepare the channel and remember that we have done so.
     
     tx_ch_desc * tx_desc = &memmap->tx_descs[tx_channel];
-    u16 rd_ptr;
-    u16 wr_ptr;
+    u32 rd_ptr;
+    u32 wr_ptr;
     u16 channel = vcc->channel;
     
     unsigned long flags;

Re: fix sparse warning in horizon atm driver.

[David S. Miller]

From: "chas williams - CONTRACTOR" <chas@cmf.nrl.navy.mil>
Date: Thu, 10 Nov 2005 11:00:39 -0500

> [ATM]: [horizon] fix sparse warnings
> 
> Signed-off-by: Dave Jones <davej@redhat.com>
> Signed-off-by: Chas Williams <cmas@cmf.nrl.navy.mil>

Applied, thanks everyone.