[PATCH] Enable exporting of nmi_callback functions for x86_64 privilege domains

[PATCH] Enable exporting of nmi_callback functions for x86_64 privilege domains

[Puthiyaparambil, Aravindh]

[-- Attachment #1: Type: text/plain, Size: 81 bytes --]


Signed off by Aravindh Puthiyaparambil
<aravindh.puthiyaparambil@unisys.com>

[-- Attachment #2: x8664_ksyms.c.diff --]
[-- Type: application/octet-stream, Size: 662 bytes --]

--- original/xen-unstable.hg/linux-2.6-xen-sparse/arch/xen/x86_64/kernel/x8664_ksyms.c	2005-10-21 14:27:26.000000000 -0400
+++ xen-unstable.hg/linux-2.6-xen-sparse/arch/xen/x86_64/kernel/x8664_ksyms.c	2005-11-08 12:35:59.000000000 -0500
@@ -128,8 +128,10 @@ EXPORT_SYMBOL(get_wchan);
 
 EXPORT_SYMBOL(rtc_lock);
 
-/* EXPORT_SYMBOL_GPL(set_nmi_callback);
-   EXPORT_SYMBOL_GPL(unset_nmi_callback); */
+#ifdef CONFIG_XEN_PRIVILEGED_GUEST
+EXPORT_SYMBOL_GPL(set_nmi_callback);
+EXPORT_SYMBOL_GPL(unset_nmi_callback);
+#endif
 
 /* Export string functions. We normally rely on gcc builtin for most of these,
    but gcc sometimes decides not to inline them. */    

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] Enable exporting of nmi_callback functions for x86_64 privilege domains

[Jan Beulich]

I disagree to that. Instead (even in the main kernel, and also on i386)
nmi_callback should completely go away, and the supposedly one user
should instead use the DIE_NMI and/or DIE_NMI_IPI notifiers.

Jan

>>> "Puthiyaparambil, Aravindh" <aravindh.puthiyaparambil@unisys.com>
09.11.05 21:03:45 >>>

Signed off by Aravindh Puthiyaparambil
<aravindh.puthiyaparambil@unisys.com>

Re: [PATCH] Enable exporting of nmi_callback functions for x86_64 privilege domains

[Andi Kleen]

On Thursday 10 November 2005 09:41, Jan Beulich wrote:
> I disagree to that. Instead (even in the main kernel, and also on i386)
> nmi_callback should completely go away, and the supposedly one user
> should instead use the DIE_NMI and/or DIE_NMI_IPI notifiers.

I agree with Jan on that.

Haven't see the original patch, but normally it's Linux policy
to not merge EXPORT_SYMBOLs if there are no modular
users of the symbol in tree.

-Andi

RE: [PATCH] Enable exporting of nmi_callback functions for x86_64 privilege domains

[Puthiyaparambil, Aravindh]

> On Thursday 10 November 2005 09:41, Jan Beulich wrote:
> > I disagree to that. Instead (even in the main kernel, and also on
i386)
> > nmi_callback should completely go away, and the supposedly one user
> > should instead use the DIE_NMI and/or DIE_NMI_IPI notifiers.

I submitted the patch only because I found that the nmi_callback
functions were being exported in all kernels except the Xen x86_64 one.
I did not realize that they are going away. We are using the functions
in one of our internal modules and I will look into moving away from
using them.


> Haven't see the original patch, but normally it's Linux policy
> to not merge EXPORT_SYMBOLs if there are no modular
> users of the symbol in tree.

I am a little confused here. If that's the case, then why are the
nmi_callback symbols being exported in all kernels but the Xen x86_64
one? I see that it is also being exported in the SLES9 SP2 kernel.

Thanks,
Aravindh