From: Andi Kleen <ak@suse.de>
To: Magnus Damm <magnus@valinux.co.jp>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, pj@sgi.com
Subject: Re: [PATCH 01/05] NUMA: Generic code
Date: Fri, 11 Nov 2005 05:16:35 +0100 [thread overview]
Message-ID: <200511110516.37980.ak@suse.de> (raw)
In-Reply-To: <20051110090925.8083.45887.sendpatchset@cherry.local>
On Thursday 10 November 2005 10:08, Magnus Damm wrote:
> Generic CONFIG_NUMA_EMU code.
>
> This patch adds generic NUMA emulation code to the kernel. The code
> provides the architectures with functions that calculate the size of
> emulated nodes, together with configuration stuff such as Kconfig and
> kernel command line code.
IMHO making it generic and bloated like this is total overkill
for this simple debugginghack. I think it is better to keep
it simple and hiden it in a architecture specific dark corners, not expose it
like this.
I think the patch shouldn't be applied.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@suse.de>
To: Magnus Damm <magnus@valinux.co.jp>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, pj@sgi.com
Subject: Re: [PATCH 01/05] NUMA: Generic code
Date: Fri, 11 Nov 2005 05:16:35 +0100 [thread overview]
Message-ID: <200511110516.37980.ak@suse.de> (raw)
In-Reply-To: <20051110090925.8083.45887.sendpatchset@cherry.local>
On Thursday 10 November 2005 10:08, Magnus Damm wrote:
> Generic CONFIG_NUMA_EMU code.
>
> This patch adds generic NUMA emulation code to the kernel. The code
> provides the architectures with functions that calculate the size of
> emulated nodes, together with configuration stuff such as Kconfig and
> kernel command line code.
IMHO making it generic and bloated like this is total overkill
for this simple debugginghack. I think it is better to keep
it simple and hiden it in a architecture specific dark corners, not expose it
like this.
I think the patch shouldn't be applied.
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-11-11 4:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-10 9:08 [PATCH 00/05][RFC] NUMA emulation update Magnus Damm
2005-11-10 9:08 ` [PATCH 01/05] NUMA: Generic code Magnus Damm
2005-11-11 4:16 ` Andi Kleen [this message]
2005-11-11 4:16 ` Andi Kleen
2005-11-15 8:34 ` Magnus Damm
2005-11-15 8:34 ` Magnus Damm
2005-11-15 14:15 ` Andi Kleen
2005-11-15 14:15 ` Andi Kleen
2005-11-16 5:22 ` Magnus Damm
2005-11-16 5:22 ` Magnus Damm
2005-11-16 7:48 ` Andi Kleen
2005-11-16 7:48 ` Andi Kleen
2005-11-16 7:57 ` Magnus Damm
2005-11-16 7:57 ` Magnus Damm
2005-11-16 8:38 ` Andi Kleen
2005-11-16 8:38 ` Andi Kleen
2005-11-16 11:31 ` Werner Almesberger
2005-11-16 11:31 ` Werner Almesberger
2005-11-10 9:08 ` [PATCH 02/05] x86_64: NUMA cleanup Magnus Damm
2005-11-10 9:08 ` [PATCH 03/05] x86_64: NUMA emulation Magnus Damm
2005-11-10 9:08 ` [PATCH 04/05] x86_64: NUMA without SMP Magnus Damm
2005-11-10 9:08 ` [PATCH 05/05] NUMA: find_next_best_node fix Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200511110516.37980.ak@suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=magnus@valinux.co.jp \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.