RE: patch to bus_add_device to delay call to device_attach till a fter "bus" and bus id sym links are set up

RE: patch to bus_add_device to delay call to device_attach till a fter "bus" and bus id sym links are set up

[goggin, edward]

> -----Original Message-----
> From: Greg KH [mailto:greg@kroah.com] 
> Sent: Thursday, November 10, 2005 5:40 PM
> To: goggin, edward
> Cc: 'dm-devel@redhat.com'
> Subject: Re: patch to bus_add_device to delay call to 
> device_attach till after "bus" and bus id sym links are set up
> 
> On Thu, Nov 10, 2005 at 03:03:53PM -0500, goggin, edward wrote:
> > Resend (hopefully) without line wrap.
> 
> Nope, linewrap still there :(
> 
> As well as a lack of Signed-off-by: line :(
> 
> > Patch to drivers/base/bus.c:bus_add_device to delay the 
> driver_attach
> > call until after the "bus" and bus_id symbolic links for 
> the device exist
> > so that a hotplug/uevent handler will not fail to find 
> these links already
> > established for a newly added device.
> 
> What version of udev are you running that causes you to see this
> problem?

Using uevents not hotplug events.  Uevent handler is in multipathd.
Udev is not involved.

> 
> > --- ../base/linux-2.6.14-rc4
> 
> Lots of stuff has changed in the driver core since 
> 2.6.14-rc4, you might
> need to update this and your other patch to the latest -git tree.

Good idea.  I'll do that and retest.

> 
> thanks,
> 
> greg k-h
> 

Re: patch to bus_add_device to delay call to device_attach till a fter "bus" and bus id sym links are set up

[Greg KH]

On Thu, Nov 10, 2005 at 08:40:43PM -0500, goggin, edward wrote:
> > -----Original Message-----
> > From: Greg KH [mailto:greg@kroah.com] 
> > Sent: Thursday, November 10, 2005 5:40 PM
> > To: goggin, edward
> > Cc: 'dm-devel@redhat.com'
> > Subject: Re: patch to bus_add_device to delay call to 
> > device_attach till after "bus" and bus id sym links are set up
> > 
> > On Thu, Nov 10, 2005 at 03:03:53PM -0500, goggin, edward wrote:
> > > Resend (hopefully) without line wrap.
> > 
> > Nope, linewrap still there :(
> > 
> > As well as a lack of Signed-off-by: line :(
> > 
> > > Patch to drivers/base/bus.c:bus_add_device to delay the 
> > driver_attach
> > > call until after the "bus" and bus_id symbolic links for 
> > the device exist
> > > so that a hotplug/uevent handler will not fail to find 
> > these links already
> > > established for a newly added device.
> > 
> > What version of udev are you running that causes you to see this
> > problem?
> 
> Using uevents not hotplug events.  Uevent handler is in multipathd.
> Udev is not involved.

See my previous comment about how you should make it involved :)

thanks,

greg k-h