[RFC] rename set-vcpus -> vcpu-set

[RFC] rename set-vcpus -> vcpu-set

[Sean Dague]

[-- Attachment #1.1: Type: text/plain, Size: 920 bytes --]

This one xm command violates the previous obj-verb convention of commands,
and it would be good to change that prior to a 3.0 release.  It was really
noticable to me when doing the xm.1 documentation.

I propose vcpu-set as there are other vcpu- commands, but other suggestions
are welcomed.

Please comment ASAP.  I'll send a patch tomorrow if there has been no
discussion, or if we've all come to some conclusion.

	-Sean

-- 
__________________________________________________________________

Sean Dague                                       Mid-Hudson Valley
sean at dague dot net                            Linux Users Group
http://dague.net                                 http://mhvlug.org

There is no silver bullet.  Plus, werewolves make better neighbors
than zombies, and they tend to keep the vampire population down.
__________________________________________________________________

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [RFC] rename set-vcpus -> vcpu-set

[Ewan Mellor]

On Tue, Nov 15, 2005 at 08:41:17AM -0500, Sean Dague wrote:

> This one xm command violates the previous obj-verb convention of commands,
> and it would be good to change that prior to a 3.0 release.  It was really
> noticable to me when doing the xm.1 documentation.
> 
> I propose vcpu-set as there are other vcpu- commands, but other suggestions
> are welcomed.

I named this set-vcpus because to me, vcpu-set means to set some property of a
VCPU, whereas this command sets a property of a domain (the number of VCPUs it
has).

However, since everyone seems to disagree with me, let's change it to
vcpu-set!

Feel free to submit a patch.  Your other ones are going in right now.

Ewan.

Re: [RFC] rename set-vcpus -> vcpu-set

[harry]

On Tue, 2005-11-15 at 14:20 +0000, Ewan Mellor wrote:
> On Tue, Nov 15, 2005 at 08:41:17AM -0500, Sean Dague wrote:
> > I propose vcpu-set as there are other vcpu- commands, but other suggestions
> > are welcomed.
> 
> I named this set-vcpus because to me, vcpu-set means to set some property of a
> VCPU, whereas this command sets a property of a domain (the number of VCPUs it
> has).
domain-set-vcpus ?!? /ducks

Re: [RFC] rename set-vcpus -> vcpu-set

[Sean Dague]

[-- Attachment #1.1: Type: text/plain, Size: 1265 bytes --]

On Tue, Nov 15, 2005 at 02:20:38PM +0000, Ewan Mellor wrote:
> On Tue, Nov 15, 2005 at 08:41:17AM -0500, Sean Dague wrote:
> 
> > This one xm command violates the previous obj-verb convention of commands,
> > and it would be good to change that prior to a 3.0 release.  It was really
> > noticable to me when doing the xm.1 documentation.
> > 
> > I propose vcpu-set as there are other vcpu- commands, but other suggestions
> > are welcomed.
> 
> I named this set-vcpus because to me, vcpu-set means to set some property of a
> VCPU, whereas this command sets a property of a domain (the number of VCPUs it
> has).

Most of the commands are obj-verb with domain/host implied.  (i.e. mem-set,
block-attach, etc.).  Just going with existing convention. :)

	-Sean

-- 
__________________________________________________________________

Sean Dague                                       Mid-Hudson Valley
sean at dague dot net                            Linux Users Group
http://dague.net                                 http://mhvlug.org

There is no silver bullet.  Plus, werewolves make better neighbors
than zombies, and they tend to keep the vampire population down.
__________________________________________________________________

[-- Attachment #1.2: Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel