From: Con Kolivas <kernel@kolivas.org>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: linux-mm <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] mm: is_dma_zone
Date: Fri, 18 Nov 2005 01:19:00 +1100 [thread overview]
Message-ID: <200511180119.01250.kernel@kolivas.org> (raw)
In-Reply-To: <1132236943.5834.70.camel@localhost>
On Fri, 18 Nov 2005 01:15, Dave Hansen wrote:
> On Fri, 2005-11-18 at 00:59 +1100, Con Kolivas wrote:
> > +static inline int is_dma(struct zone *zone)
> > +{
> > + return zone == zone->zone_pgdat->node_zones + ZONE_DMA;
> > +}
>
> Any reason you can't just use 'zone_idx(z) == ZONE_DMA' here, just like
> the code you replaced?
I was just following the style of the is_highmem and is_normal immediately
preceeding this. No strong reason otherwise.
Cheers,
Con
WARNING: multiple messages have this Message-ID (diff)
From: Con Kolivas <kernel@kolivas.org>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: linux-mm <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] mm: is_dma_zone
Date: Fri, 18 Nov 2005 01:19:00 +1100 [thread overview]
Message-ID: <200511180119.01250.kernel@kolivas.org> (raw)
In-Reply-To: <1132236943.5834.70.camel@localhost>
On Fri, 18 Nov 2005 01:15, Dave Hansen wrote:
> On Fri, 2005-11-18 at 00:59 +1100, Con Kolivas wrote:
> > +static inline int is_dma(struct zone *zone)
> > +{
> > + return zone == zone->zone_pgdat->node_zones + ZONE_DMA;
> > +}
>
> Any reason you can't just use 'zone_idx(z) == ZONE_DMA' here, just like
> the code you replaced?
I was just following the style of the is_highmem and is_normal immediately
preceeding this. No strong reason otherwise.
Cheers,
Con
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-11-17 14:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-17 13:59 [PATCH] mm: is_dma_zone Con Kolivas
2005-11-17 13:59 ` Con Kolivas
2005-11-17 14:15 ` Dave Hansen
2005-11-17 14:15 ` Dave Hansen
2005-11-17 14:19 ` Con Kolivas [this message]
2005-11-17 14:19 ` Con Kolivas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200511180119.01250.kernel@kolivas.org \
--to=kernel@kolivas.org \
--cc=akpm@osdl.org \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.