From: Andi Kleen <ak@suse.de>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@osdl.org
Subject: Re: [PATCH] NUMA policies in the slab allocator V2
Date: Fri, 18 Nov 2005 03:59:17 +0100 [thread overview]
Message-ID: <200511180359.17598.ak@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.62.0511171745410.22486@schroedinger.engr.sgi.com>
On Friday 18 November 2005 02:51, Christoph Lameter wrote:
> This patch fixes a regression in 2.6.14 against 2.6.13 that causes an
> imbalance in memory allocation during bootup.
I still think it's wrongly implemented. We shouldn't be slowing down the slab
fast path for this. Also BTW if anything your check would need to be
dependent on !in_interrupt(), otherwise the policy of slab allocations
in interrupt context will change randomly based on what the current
process is doing (that's wrong, interrupts should be always local)
But of course that would make the fast path even slower ...
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <ak@suse.de>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@osdl.org
Subject: Re: [PATCH] NUMA policies in the slab allocator V2
Date: Fri, 18 Nov 2005 03:59:17 +0100 [thread overview]
Message-ID: <200511180359.17598.ak@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.62.0511171745410.22486@schroedinger.engr.sgi.com>
On Friday 18 November 2005 02:51, Christoph Lameter wrote:
> This patch fixes a regression in 2.6.14 against 2.6.13 that causes an
> imbalance in memory allocation during bootup.
I still think it's wrongly implemented. We shouldn't be slowing down the slab
fast path for this. Also BTW if anything your check would need to be
dependent on !in_interrupt(), otherwise the policy of slab allocations
in interrupt context will change randomly based on what the current
process is doing (that's wrong, interrupts should be always local)
But of course that would make the fast path even slower ...
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-11-18 3:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-18 1:51 [PATCH] NUMA policies in the slab allocator V2 Christoph Lameter
2005-11-18 1:51 ` Christoph Lameter
2005-11-18 2:59 ` Andi Kleen [this message]
2005-11-18 2:59 ` Andi Kleen
2005-11-18 3:38 ` Christoph Lameter
2005-11-18 3:38 ` Christoph Lameter
2005-11-18 4:31 ` Andi Kleen
2005-11-18 4:31 ` Andi Kleen
2005-11-18 17:19 ` Christoph Lameter
2005-11-18 17:19 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200511180359.17598.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=clameter@engr.sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.